third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp - Issue 2782893002: WebMouseEvent coordinates are now fractional & private

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp

Issue 2782893002: WebMouseEvent coordinates are now fractional & private (Closed)

Patch Set: Rebased, fixed a comment in web_input_event_builders_mac.mm Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp b/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp

index dbb513513e85425ace3406a1d4b203faca88907e..fa53cf4be94d6f5fdaa592e667ebd34d4fd8f577 100644

--- a/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp

+++ b/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp

@@ -771,7 +771,7 @@ void WebFrameWidgetImpl::handleMouseDown(LocalFrame& mainFrame,

// Take capture on a mouse down on a plugin so we can send it mouse events.

// If the hit node is a plugin but a scrollbar is over it don't start mouse

// capture because it will interfere with the scrollbar receiving events.

- IntPoint point(event.x, event.y);

+ IntPoint point(event.positionInWidget().x, event.positionInWidget().y);

if (event.button == WebMouseEvent::Button::Left) {

point = m_localRoot->frameView()->rootFrameToContents(point);

HitTestResult result(