WebMouseEvent coordinates are now fractional & private

third_party/WebKit/public/platform/WebMouseEvent.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef WebMouseEvent_h
 #define WebMouseEvent_h
 
 #include "WebInputEvent.h"
 
 namespace blink {
 
 class WebGestureEvent;
 
 // See WebInputEvent.h for details why this pack is here.
 #pragma pack(push, 4)
 
 // WebMouseEvent --------------------------------------------------------------
 
 class WebMouseEvent : public WebInputEvent, public WebPointerProperties {
  public:
-  // Renderer coordinates. Similar to viewport coordinates but without
-  // DevTools emulation transform or overscroll applied. i.e. the coordinates
-  // in Chromium's RenderView bounds.
-  int x;
-  int y;
-
-  // Screen coordinate
-  int globalX;
-  int globalY;
-
   int clickCount;
 
   WebMouseEvent(Type typeParam,
                 int xParam,
                 int yParam,
                 int globalXParam,
                 int globalYParam,
                 int modifiersParam,
                 double timeStampSecondsParam)
       : WebInputEvent(sizeof(WebMouseEvent),
                       typeParam,
                       modifiersParam,
                       timeStampSecondsParam),
         WebPointerProperties(),
-        x(xParam),
-        y(yParam),
-        globalX(globalXParam),
-        globalY(globalYParam) {}
+        m_positionInWidget(xParam, yParam),
+        m_positionInScreen(globalXParam, globalYParam) {}
 
   WebMouseEvent(Type typeParam,
                 WebFloatPoint position,
                 WebFloatPoint globalPosition,
                 Button buttonParam,
                 int clickCountParam,
                 int modifiersParam,
                 double timeStampSecondsParam)
       : WebInputEvent(sizeof(WebMouseEvent),
                       typeParam,
                       modifiersParam,
                       timeStampSecondsParam),
         WebPointerProperties(buttonParam, PointerType::Mouse),
-        x(position.x),
-        y(position.y),
-        globalX(globalPosition.x),
-        globalY(globalPosition.y),
-        clickCount(clickCountParam) {}
+        clickCount(clickCountParam),
+        m_positionInWidget(floor(position.x), floor(position.y)),

[dtapuska, 2017/03/31 14:04:18]

Can we add a comment regarding the floor... referencing an open bug?

[mustaq, 2017/03/31 15:50:32]

Added a class comment above.

+        m_positionInScreen(floor(globalPosition.x), floor(globalPosition.y)) {}
 
   WebMouseEvent(Type typeParam,
                 int modifiersParam,
                 double timeStampSecondsParam)
       : WebMouseEvent(sizeof(WebMouseEvent),
                       typeParam,
                       modifiersParam,
                       timeStampSecondsParam) {}
 
   WebMouseEvent() : WebMouseEvent(sizeof(WebMouseEvent)) {}
@@ skipping 11 matching lines @@
                                       double timeStampSecondsParam);
 
   BLINK_PLATFORM_EXPORT WebFloatPoint movementInRootFrame() const;
   BLINK_PLATFORM_EXPORT WebFloatPoint positionInRootFrame() const;
 
   // Sets any scaled values to be their computed values and sets |frameScale|
   // back to 1 and |translateX|, |translateY| back to 0.
   BLINK_PLATFORM_EXPORT WebMouseEvent flattenTransform() const;
 #endif
 
+  WebFloatPoint positionInWidget() const { return m_positionInWidget; }
+  void setPositionInWidget(float x, float y) {
+    m_positionInWidget = WebFloatPoint(floor(x), floor(y));

[dtapuska, 2017/03/31 14:04:18]

Same as why we are doing the floor...

[mustaq, 2017/03/31 15:50:32]

Ditto.

+  }
+
+  WebFloatPoint positionInScreen() const { return m_positionInScreen; }
+  void setPositionInScreen(float x, float y) {
+    m_positionInScreen = WebFloatPoint(floor(x), floor(y));

[dtapuska, 2017/03/31 14:04:18]

here too :-)

[mustaq, 2017/03/31 15:50:32]

Ditto too :-)

+  }
+
  protected:
   explicit WebMouseEvent(unsigned sizeParam)
       : WebInputEvent(sizeParam), WebPointerProperties() {}
 
   WebMouseEvent(unsigned sizeParam,
                 Type type,
                 int modifiers,
                 double timeStampSeconds)
       : WebInputEvent(sizeParam, type, modifiers, timeStampSeconds),
         WebPointerProperties() {}
 
   void flattenTransformSelf();
+
+ private:
+  // Widget coordinates, i.e., the coordinates in Chromium's RenderView
+  // bounds. Similar to viewport coordinates but without DevTools emulation
+  // transform or overscroll applied.
+  WebFloatPoint m_positionInWidget;
+
+  // Screen coordinate
+  WebFloatPoint m_positionInScreen;
 };
 
 #pragma pack(pop)
 
 }  // namespace blink
 
 #endif  // WebMouseEvent_h