third_party/WebKit/Source/core/events/MouseEvent.cpp - Issue 2782893002: WebMouseEvent coordinates are now fractional & private

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/events/MouseEvent.cpp

Issue 2782893002: WebMouseEvent coordinates are now fractional & private (Closed)

Patch Set: Rebased, fixed a comment in web_input_event_builders_mac.mm Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/events/MouseEvent.cpp

diff --git a/third_party/WebKit/Source/core/events/MouseEvent.cpp b/third_party/WebKit/Source/core/events/MouseEvent.cpp

index 46290ee336f7b8e5ff54e53774ac6e1938ba57e1..7e8c7ecddd050c2c83e12f4da0d602d550c75057 100644

--- a/third_party/WebKit/Source/core/events/MouseEvent.cpp

+++ b/third_party/WebKit/Source/core/events/MouseEvent.cpp

@@ -168,7 +168,7 @@ MouseEvent::MouseEvent(const AtomicString& eventType,

? abstractView->getInputDeviceCapabilities()->firesTouchEvents(

event.fromTouch())

: nullptr),

- m_screenLocation(event.globalX, event.globalY),

+ m_screenLocation(event.positionInScreen().x, event.positionInScreen().y),

m_movementDelta(flooredIntPoint(event.movementInRootFrame())),

m_positionType(PositionType::Position),

m_button(static_cast<short>(event.button)),