WebMouseEvent coordinates are now fractional & private

content/browser/renderer_host/input/synthetic_gesture_controller_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/input/synthetic_gesture_controller.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <memory>
@@ skipping 229 matching lines @@
   MockDragMouseTarget() : started_(false) {}
   ~MockDragMouseTarget() override {}
 
   void DispatchInputEventToPlatform(const WebInputEvent& event) override {
     ASSERT_TRUE(WebInputEvent::isMouseEventType(event.type()));
     const WebMouseEvent& mouse_event = static_cast<const WebMouseEvent&>(event);
     if (!started_) {
       EXPECT_EQ(mouse_event.button, WebMouseEvent::Button::Left);
       EXPECT_EQ(mouse_event.clickCount, 1);
       EXPECT_EQ(mouse_event.type(), WebInputEvent::MouseDown);
-      start_.SetPoint(mouse_event.x, mouse_event.y);
+      start_.SetPoint(mouse_event.positionInWidget().x,
+                      mouse_event.positionInWidget().y);
       last_mouse_point_ = start_;
       started_ = true;
     } else {
       EXPECT_EQ(mouse_event.button, WebMouseEvent::Button::Left);
       ASSERT_NE(mouse_event.type(), WebInputEvent::MouseDown);
 
-      gfx::PointF mouse_point(mouse_event.x, mouse_event.y);
+      gfx::PointF mouse_point(mouse_event.positionInWidget().x,

[dtapuska, 2017/03/31 14:04:18]

I think this can be mouse_event.poisitionInWidget()

there is an implicit conversion from WebFloatPoint -> gfx::PointF
(https://cs.chromium.org/chromium/src/third_party/WebKit/public/platform/WebFl...)

[mustaq, 2017/03/31 15:50:31]

Done.

+                              mouse_event.positionInWidget().y);
       gfx::Vector2dF delta = mouse_point - last_mouse_point_;
       total_abs_move_distance_length_ += delta.Length();
       if (mouse_event.type() == WebInputEvent::MouseUp)
         start_to_end_distance_ = mouse_point - start_;
       last_mouse_point_ = mouse_point;
     }
   }
 
  private:
   bool started_;
@@ skipping 215 matching lines @@
 
   void DispatchInputEventToPlatform(const WebInputEvent& event) override {
     ASSERT_TRUE(WebInputEvent::isMouseEventType(event.type()));
     const WebMouseEvent& mouse_event = static_cast<const WebMouseEvent&>(event);
 
     switch (state_) {
       case NOT_STARTED:
         EXPECT_EQ(mouse_event.type(), WebInputEvent::MouseDown);
         EXPECT_EQ(mouse_event.button, WebMouseEvent::Button::Left);
         EXPECT_EQ(mouse_event.clickCount, 1);
-        position_ = gfx::PointF(mouse_event.x, mouse_event.y);
+        position_ = gfx::PointF(mouse_event.positionInWidget().x,
+                                mouse_event.positionInWidget().y);
         start_time_ = base::TimeDelta::FromMilliseconds(
             static_cast<int64_t>(mouse_event.timeStampSeconds() * 1000));
         state_ = STARTED;
         break;
       case STARTED:
         EXPECT_EQ(mouse_event.type(), WebInputEvent::MouseUp);
         EXPECT_EQ(mouse_event.button, WebMouseEvent::Button::Left);
         EXPECT_EQ(mouse_event.clickCount, 1);
-        EXPECT_EQ(position_, gfx::PointF(mouse_event.x, mouse_event.y));
+        EXPECT_EQ(position_, gfx::PointF(mouse_event.positionInWidget().x,
+                                         mouse_event.positionInWidget().y));
         stop_time_ = base::TimeDelta::FromMilliseconds(
             static_cast<int64_t>(mouse_event.timeStampSeconds() * 1000));
         state_ = FINISHED;
         break;
       case FINISHED:
         EXPECT_FALSE(true);
         break;
     }
   }
 };
@@ skipping 89 matching lines @@
 class MockSyntheticPointerMouseActionTarget
     : public MockSyntheticPointerActionTarget {
  public:
   MockSyntheticPointerMouseActionTarget() {}
   ~MockSyntheticPointerMouseActionTarget() override {}
 
   void DispatchInputEventToPlatform(const WebInputEvent& event) override {
     ASSERT_TRUE(WebInputEvent::isMouseEventType(event.type()));
     const WebMouseEvent& mouse_event = static_cast<const WebMouseEvent&>(event);
     type_ = mouse_event.type();
-    position_ = gfx::PointF(mouse_event.x, mouse_event.y);
+    position_ = gfx::PointF(mouse_event.positionInWidget().x,
+                            mouse_event.positionInWidget().y);
     clickCount_ = mouse_event.clickCount;
     button_ = mouse_event.button;
     num_actions_dispatched_++;
   }
 
   testing::AssertionResult SyntheticMouseActionDispatchedCorrectly(
       const SyntheticPointerActionParams& param,
       int click_count) {
     if (type_ != ToWebMouseEventType(param.pointer_action_type())) {
       return testing::AssertionFailure()
@@ skipping 1137 matching lines @@
   EXPECT_EQ(4, num_success_);
   EXPECT_EQ(0, num_failure_);
   EXPECT_EQ(pointer_mouse_target->num_actions_dispatched(), 4);
   EXPECT_TRUE(
       pointer_mouse_target->SyntheticMouseActionDispatchedCorrectly(param, 1));
 }
 
 }  // namespace
 
 }  // namespace content