WebMouseEvent coordinates are now fractional & private

third_party/WebKit/public/platform/WebMouseEvent.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef WebMouseEvent_h
 #define WebMouseEvent_h
 
 #include "WebInputEvent.h"
 
 namespace blink {
 
 class WebGestureEvent;
 
 // See WebInputEvent.h for details why this pack is here.
 #pragma pack(push, 4)
 
 // WebMouseEvent --------------------------------------------------------------
 
 class WebMouseEvent : public WebInputEvent, public WebPointerProperties {
  public:
   // Renderer coordinates. Similar to viewport coordinates but without
   // DevTools emulation transform or overscroll applied. i.e. the coordinates
   // in Chromium's RenderView bounds.
-  int x;
-  int y;
+  WebFloatPoint position;

[dtapuska, 2017/03/29 20:19:15]

I think we really should move these to be accessors like

positionInScreen()
and
positionInView()

that will go a long way in making this class struct like and more OO like.

[mustaq, 2017/03/30 21:01:35]

Done, all done, phew!

 
   // Screen coordinate
-  int globalX;
-  int globalY;
+  WebFloatPoint screenPosition;
 
   int clickCount;
 
   WebMouseEvent(Type typeParam,
                 int xParam,
                 int yParam,
                 int globalXParam,
                 int globalYParam,
                 int modifiersParam,
                 double timeStampSecondsParam)
       : WebInputEvent(sizeof(WebMouseEvent),
                       typeParam,
                       modifiersParam,
                       timeStampSecondsParam),
         WebPointerProperties(),
-        x(xParam),
-        y(yParam),
-        globalX(globalXParam),
-        globalY(globalYParam) {}
+        position(xParam, yParam),
+        screenPosition(WebFloatPoint(globalXParam, globalYParam)) {}
 
   WebMouseEvent(Type typeParam,
                 WebFloatPoint position,
                 WebFloatPoint globalPosition,
                 Button buttonParam,
                 int clickCountParam,
                 int modifiersParam,
                 double timeStampSecondsParam)
       : WebInputEvent(sizeof(WebMouseEvent),
                       typeParam,
                       modifiersParam,
                       timeStampSecondsParam),
         WebPointerProperties(buttonParam, PointerType::Mouse),
-        x(position.x),
-        y(position.y),
-        globalX(globalPosition.x),
-        globalY(globalPosition.y),
+        position(position),
+        screenPosition(globalPosition),
         clickCount(clickCountParam) {}
 
   WebMouseEvent(Type typeParam,
                 int modifiersParam,
                 double timeStampSecondsParam)
       : WebMouseEvent(sizeof(WebMouseEvent),
                       typeParam,
                       modifiersParam,
                       timeStampSecondsParam) {}
 
@@ skipping 31 matching lines @@
         WebPointerProperties() {}
 
   void flattenTransformSelf();
 };
 
 #pragma pack(pop)
 
 }  // namespace blink
 
 #endif  // WebMouseEvent_h