WebMouseEvent coordinates are now fractional & private

third_party/WebKit/Source/platform/WebMouseEvent.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "public/platform/WebMouseEvent.h"
 
 #include "public/platform/WebGestureEvent.h"
 
 namespace blink {
 
 WebMouseEvent::WebMouseEvent(WebInputEvent::Type type,
                              const WebGestureEvent& gestureEvent,
                              Button buttonParam,
                              int clickCountParam,
                              int modifiers,
                              double timeStampSeconds)
     : WebInputEvent(sizeof(WebMouseEvent), type, modifiers, timeStampSeconds),
       WebPointerProperties(buttonParam,
                            WebPointerProperties::PointerType::Mouse),
-      x(gestureEvent.x),
-      y(gestureEvent.y),
-      globalX(gestureEvent.globalX),
-      globalY(gestureEvent.globalY),
-      clickCount(clickCountParam) {
+      clickCount(clickCountParam),
+      m_positionInWidget(WebFloatPoint(gestureEvent.x, gestureEvent.y)),

[dtapuska, 2017/03/31 14:04:18]

This is odd. Do you require the extra WebFloatPoint here (and the line below)

[mustaq, 2017/03/31 15:50:31]

Thanks for the catch, done.

+      m_positionInScreen(
+          WebFloatPoint(gestureEvent.globalX, gestureEvent.globalY)) {
   setFrameScale(gestureEvent.frameScale());
   setFrameTranslate(gestureEvent.frameTranslate());
 }
 
 WebFloatPoint WebMouseEvent::movementInRootFrame() const {
   return WebFloatPoint((movementX / m_frameScale), (movementY / m_frameScale));
 }
 
 WebFloatPoint WebMouseEvent::positionInRootFrame() const {
-  return WebFloatPoint((x / m_frameScale) + m_frameTranslate.x,
-                       (y / m_frameScale) + m_frameTranslate.y);
+  return WebFloatPoint(
+      (m_positionInWidget.x / m_frameScale) + m_frameTranslate.x,
+      (m_positionInWidget.y / m_frameScale) + m_frameTranslate.y);
 }
 
 WebMouseEvent WebMouseEvent::flattenTransform() const {
   WebMouseEvent result = *this;
   result.flattenTransformSelf();
   return result;
 }
 
 void WebMouseEvent::flattenTransformSelf() {
-  x = (x / m_frameScale) + m_frameTranslate.x;
-  y = (y / m_frameScale) + m_frameTranslate.y;
+  m_positionInWidget.x =
+      floor((m_positionInWidget.x / m_frameScale) + m_frameTranslate.x);

[dtapuska, 2017/03/31 14:04:18]

Can we add a comment why we are taking the floor? Referencing the bug #.

[mustaq, 2017/03/31 15:50:32]

Added a comment in the class header.

+  m_positionInWidget.y =
+      floor((m_positionInWidget.y / m_frameScale) + m_frameTranslate.y);
   m_frameTranslate.x = 0;
   m_frameTranslate.y = 0;
   m_frameScale = 1;
 }
 
 }  // namespace blink