Move TestingPrefService to use unique_ptr<Value>

Move TestingPrefService to use unique_ptr<Value>

Various Set*Pref methods of TestingPrefService pass Value ownership with a raw
pointer.

This CL changes that to passing unique_ptr, because that is a safer and clearer
option. It is also a pre-requisite for migrating Value API off raw pointer
ownership passing.

BUG=697817
Review-Url: https://codereview.chromium.org/2782553004
Cr-Commit-Position: refs/heads/master@{#460363}
Committed: https://chromium.googlesource.com/chromium/src/+/8684c9acc69aa307f5fabfef0182b61c7fe8ce00

[vabr (Chromium), 2017-03-28 14:05:58]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 14:06:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 14:10:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 14:10:27]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[vabr (Chromium), 2017-03-28 14:21:01]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 14:21:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 14:31:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 14:31:09]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)

[vabr (Chromium), 2017-03-28 14:40:40]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 14:41:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 14:59:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 14:59:37]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[vabr (Chromium), 2017-03-28 15:22:37]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 15:23:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 16:14:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 16:14:29]

Dry run: This issue passed the CQ dry run.

[vabr (Chromium), 2017-03-28 16:25:46]

Description was changed from

==========
Move TestingPrefService to use unique_ptr<Value>

Various Set*Pref methods of TestingPrefService pass Value ownership with a raw
pointer.

This CL changes that to passing unique_ptr, because that is a safer and clearer
option. It is also a pre-requisite for migrating Value API off raw pointer
ownership passing.

BUG=697817
==========

to

==========
Move TestingPrefService to use unique_ptr<Value>

Various Set*Pref methods of TestingPrefService pass Value ownership with a raw
pointer.

This CL changes that to passing unique_ptr, because that is a safer and clearer
option. It is also a pre-requisite for migrating Value API off raw pointer
ownership passing.

BUG=697817
==========

[vabr (Chromium), 2017-03-28 16:25:46]

vabr@chromium.org changed reviewers:
+ derat@chromium.org

[vabr (Chromium), 2017-03-28 16:30:16]

Description was changed from

==========
Move TestingPrefService to use unique_ptr<Value>

Various Set*Pref methods of TestingPrefService pass Value ownership with a raw
pointer.

This CL changes that to passing unique_ptr, because that is a safer and clearer
option. It is also a pre-requisite for migrating Value API off raw pointer
ownership passing.

BUG=697817
==========

to

==========
Move TestingPrefService to use unique_ptr<Value>

Various Set*Pref methods of TestingPrefService pass Value ownership with a raw
pointer.

This CL changes that to passing unique_ptr, because that is a safer and clearer
option. It is also a pre-requisite for migrating Value API off raw pointer
ownership passing.

BUG=697817

TBR=derat@chromium.org
==========

[vabr (Chromium), 2017-03-28 16:30:17]

vabr@chromium.org changed reviewers:
+ bauerb@chromium.org

[vabr (Chromium), 2017-03-28 16:32:13]

Description was changed from

==========
Move TestingPrefService to use unique_ptr<Value>

Various Set*Pref methods of TestingPrefService pass Value ownership with a raw
pointer.

This CL changes that to passing unique_ptr, because that is a safer and clearer
option. It is also a pre-requisite for migrating Value API off raw pointer
ownership passing.

BUG=697817

TBR=derat@chromium.org
==========

to

==========
Move TestingPrefService to use unique_ptr<Value>

Various Set*Pref methods of TestingPrefService pass Value ownership with a raw
pointer.

This CL changes that to passing unique_ptr, because that is a safer and clearer
option. It is also a pre-requisite for migrating Value API off raw pointer
ownership passing.

BUG=697817

TBR=jochen@chromium.org
==========

[vabr (Chromium), 2017-03-28 16:32:13]

vabr@chromium.org changed reviewers:
+ jochen@chromium.org
- derat@chromium.org

[vabr (Chromium), 2017-03-28 16:33:39]

Description was changed from

==========
Move TestingPrefService to use unique_ptr<Value>

Various Set*Pref methods of TestingPrefService pass Value ownership with a raw
pointer.

This CL changes that to passing unique_ptr, because that is a safer and clearer
option. It is also a pre-requisite for migrating Value API off raw pointer
ownership passing.

BUG=697817

TBR=jochen@chromium.org
==========

to

==========
Move TestingPrefService to use unique_ptr<Value>

Various Set*Pref methods of TestingPrefService pass Value ownership with a raw
pointer.

This CL changes that to passing unique_ptr, because that is a safer and clearer
option. It is also a pre-requisite for migrating Value API off raw pointer
ownership passing.

BUG=697817
==========

[vabr (Chromium), 2017-03-28 16:33:39]

vabr@chromium.org changed reviewers:
+ jdoerrie@chromium.org, sdefresne@chromium.org

[vabr (Chromium), 2017-03-28 16:37:17]

Hi all!

bauerb@, please review components/prefs/testing_pref_service.h, which is the key
change.

jdoerrie@, please spot check the rest of the CL. It is all just mechanical
changes necessary after the change to testing_pref_service.h.

jochen@, please rubber-stamp //chrome/browser and //components.

sdefresne@, please rubber-stamp
ios/chrome/browser/ui/settings/utils/pref_backed_boolean_unittest.mm

I will wait for the review from bauerb@ and jdoerrie@ and will TBR the rest if
needed.

Thanks all!

Vaclav

[jochen (gone - plz use gerrit), 2017-03-29 06:27:02]

rubberstamp lgtm

[jdoerrie, 2017-03-29 09:28:00]

Spot checked, LGTM!

https://codereview.chromium.org/2782553004/diff/80001/components/prefs/pref_c...
File components/prefs/pref_change_registrar_unittest.cc (right):

https://codereview.chromium.org/2782553004/diff/80001/components/prefs/pref_c...
components/prefs/pref_change_registrar_unittest.cc:5: #include
"components/prefs/pref_change_registrar.h"
Nit: Missing New Line

https://codereview.chromium.org/2782553004/diff/80001/ios/chrome/browser/ui/s...
File ios/chrome/browser/ui/settings/utils/pref_backed_boolean_unittest.mm
(right):

https://codereview.chromium.org/2782553004/diff/80001/ios/chrome/browser/ui/s...
ios/chrome/browser/ui/settings/utils/pref_backed_boolean_unittest.mm:39:
std::unique_ptr<base::Value> booleanValue =
Nit: auto

[vabr (Chromium), 2017-03-29 09:43:13]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 09:43:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vabr (Chromium), 2017-03-29 09:43:56]

Thanks!

Once bauerb@ is happy with components/prefs/testing_pref_service.h I will send
to CQ.

Cheers,
Vaclav

https://codereview.chromium.org/2782553004/diff/80001/components/prefs/pref_c...
File components/prefs/pref_change_registrar_unittest.cc (right):

https://codereview.chromium.org/2782553004/diff/80001/components/prefs/pref_c...
components/prefs/pref_change_registrar_unittest.cc:5: #include
"components/prefs/pref_change_registrar.h"
On 2017/03/29 09:28:00, jdoerrie wrote:
> Nit: Missing New Line

Thanks for catching this! Turns out clang-format moved this header up (to
conform with
https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes),
but does not add blank lines separators. Will file a bug for that.

https://codereview.chromium.org/2782553004/diff/80001/ios/chrome/browser/ui/s...
File ios/chrome/browser/ui/settings/utils/pref_backed_boolean_unittest.mm
(right):

https://codereview.chromium.org/2782553004/diff/80001/ios/chrome/browser/ui/s...
ios/chrome/browser/ui/settings/utils/pref_backed_boolean_unittest.mm:39:
std::unique_ptr<base::Value> booleanValue =
On 2017/03/29 09:28:00, jdoerrie wrote:
> Nit: auto

Done.

[vabr (Chromium), 2017-03-29 09:54:23]

> Thanks for catching this! Turns out clang-format moved this header up (to
> conform with
>
https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes),
> but does not add blank lines separators. Will file a bug for that.

I filed an internal bug # 36705544.

[commit-bot: I haz the power, 2017-03-29 10:42:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 10:42:34]

Dry run: This issue passed the CQ dry run.

[sdefresne, 2017-03-29 11:04:55]

ios/chrome/browser/ui/settings/utils/pref_backed_boolean_unittest.mm lgtm

[Bernhard Bauer, 2017-03-29 11:51:50]

TestingPrefService LGTM

[vabr (Chromium), 2017-03-29 13:07:49]

The CQ bit was checked by vabr@chromium.org

[vabr (Chromium), 2017-03-29 13:07:50]

The patchset sent to the CQ was uploaded after l-g-t-m from
jdoerrie@chromium.org, jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/2782553004/#ps100001
(title: "comments")

[commit-bot: I haz the power, 2017-03-29 13:08:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 13:15:02]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1490792869506020,
"parent_rev": "908b7419b238a50d685634fa7844fd690830fa9c", "commit_rev":
"8684c9acc69aa307f5fabfef0182b61c7fe8ce00"}

[commit-bot: I haz the power, 2017-03-29 13:15:53]

Description was changed from

==========
Move TestingPrefService to use unique_ptr<Value>

Various Set*Pref methods of TestingPrefService pass Value ownership with a raw
pointer.

This CL changes that to passing unique_ptr, because that is a safer and clearer
option. It is also a pre-requisite for migrating Value API off raw pointer
ownership passing.

BUG=697817
==========

to

==========
Move TestingPrefService to use unique_ptr<Value>

Various Set*Pref methods of TestingPrefService pass Value ownership with a raw
pointer.

This CL changes that to passing unique_ptr, because that is a safer and clearer
option. It is also a pre-requisite for migrating Value API off raw pointer
ownership passing.

BUG=697817

Review-Url: https://codereview.chromium.org/2782553004
Cr-Commit-Position: refs/heads/master@{#460363}
Committed:
https://chromium.googlesource.com/chromium/src/+/8684c9acc69aa307f5fabfef0182...
==========

[commit-bot: I haz the power, 2017-03-29 13:15:56]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/8684c9acc69aa307f5fabfef0182...