Move TestingPrefService to use unique_ptr<Value>

chrome/browser/printing/cloud_print/cloud_print_proxy_service_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/printing/cloud_print/cloud_print_proxy_service.h"
 
 #include <stdint.h>
 
 #include <memory>
 #include <string>
 
 #include "base/command_line.h"
 #include "base/location.h"
+#include "base/memory/ptr_util.h"
 #include "base/message_loop/message_loop.h"
 #include "base/run_loop.h"
 #include "base/single_thread_task_runner.h"
 #include "base/threading/thread_task_runner_handle.h"
 #include "chrome/browser/printing/cloud_print/cloud_print_proxy_service_factory.h"
 #include "chrome/browser/service_process/service_process_control.h"
 #include "chrome/browser/ui/startup/startup_browser_creator.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/cloud_print/cloud_print_proxy_info.h"
 #include "chrome/common/pref_names.h"
@@ skipping 213 matching lines @@
 }
 
 TEST_F(CloudPrintProxyPolicyTest, StartWithNoPolicyProxyDisabled) {
   TestCloudPrintProxyService service(&profile_);
 
   service.GetMockServiceProcessControl()->SetConnectSuccessMockExpectations(
       MockServiceProcessControl::kServiceStateDisabled, false);
 
   sync_preferences::TestingPrefServiceSyncable* prefs =
       profile_.GetTestingPrefService();
-  prefs->SetUserPref(
-      prefs::kCloudPrintEmail,
-      new base::Value(MockServiceProcessControl::EnabledUserId()));
+  prefs->SetUserPref(prefs::kCloudPrintEmail,
+                     base::MakeUnique<base::Value>(
+                         MockServiceProcessControl::EnabledUserId()));
 
   service.Initialize();
 
   EXPECT_EQ(std::string(), prefs->GetString(prefs::kCloudPrintEmail));
 }
 
 TEST_F(CloudPrintProxyPolicyTest, StartWithNoPolicyProxyEnabled) {
   TestCloudPrintProxyService service(&profile_);
 
   service.GetMockServiceProcessControl()->SetConnectSuccessMockExpectations(
       MockServiceProcessControl::kServiceStateEnabled, false);
 
   sync_preferences::TestingPrefServiceSyncable* prefs =
       profile_.GetTestingPrefService();
-  prefs->SetUserPref(prefs::kCloudPrintEmail, new base::Value(std::string()));
+  prefs->SetUserPref(prefs::kCloudPrintEmail,
+                     base::MakeUnique<base::Value>(std::string()));
 
   service.Initialize();
   service.RefreshStatusFromService();
 
   EXPECT_EQ(MockServiceProcessControl::EnabledUserId(),
             prefs->GetString(prefs::kCloudPrintEmail));
 }
 
 TEST_F(CloudPrintProxyPolicyTest, StartWithPolicySetProxyDisabled) {
   TestCloudPrintProxyService service(&profile_);
 
   service.GetMockServiceProcessControl()->SetConnectSuccessMockExpectations(
       MockServiceProcessControl::kServiceStateDisabled, false);
 
   sync_preferences::TestingPrefServiceSyncable* prefs =
       profile_.GetTestingPrefService();
-  prefs->SetUserPref(prefs::kCloudPrintEmail, new base::Value(std::string()));
-  prefs->SetManagedPref(prefs::kCloudPrintProxyEnabled, new base::Value(false));
+  prefs->SetUserPref(prefs::kCloudPrintEmail,
+                     base::MakeUnique<base::Value>(std::string()));
+  prefs->SetManagedPref(prefs::kCloudPrintProxyEnabled,
+                        base::MakeUnique<base::Value>(false));
 
   service.Initialize();
 
   EXPECT_EQ(std::string(), prefs->GetString(prefs::kCloudPrintEmail));
 }
 
 TEST_F(CloudPrintProxyPolicyTest, StartWithPolicySetProxyEnabled) {
   TestCloudPrintProxyService service(&profile_);
 
   service.GetMockServiceProcessControl()->SetConnectSuccessMockExpectations(
       MockServiceProcessControl::kServiceStateEnabled, false);
   service.GetMockServiceProcessControl()->SetWillBeDisabledExpectations();
 
   sync_preferences::TestingPrefServiceSyncable* prefs =
       profile_.GetTestingPrefService();
-  prefs->SetUserPref(prefs::kCloudPrintEmail, new base::Value(std::string()));
-  prefs->SetManagedPref(prefs::kCloudPrintProxyEnabled, new base::Value(false));
+  prefs->SetUserPref(prefs::kCloudPrintEmail,
+                     base::MakeUnique<base::Value>(std::string()));
+  prefs->SetManagedPref(prefs::kCloudPrintProxyEnabled,
+                        base::MakeUnique<base::Value>(false));
 
   service.Initialize();
 
   EXPECT_EQ(std::string(), prefs->GetString(prefs::kCloudPrintEmail));
 }
 
 TEST_F(CloudPrintProxyPolicyTest, StartWithNoPolicyProxyDisabledThenSetPolicy) {
   TestCloudPrintProxyService service(&profile_);
 
   service.GetMockServiceProcessControl()->SetConnectSuccessMockExpectations(
       MockServiceProcessControl::kServiceStateDisabled, false);
 
   sync_preferences::TestingPrefServiceSyncable* prefs =
       profile_.GetTestingPrefService();
-  prefs->SetUserPref(
-      prefs::kCloudPrintEmail,
-      new base::Value(MockServiceProcessControl::EnabledUserId()));
+  prefs->SetUserPref(prefs::kCloudPrintEmail,
+                     base::MakeUnique<base::Value>(
+                         MockServiceProcessControl::EnabledUserId()));
 
   service.Initialize();
 
   EXPECT_EQ(std::string(), prefs->GetString(prefs::kCloudPrintEmail));
 
-  prefs->SetManagedPref(prefs::kCloudPrintProxyEnabled, new base::Value(false));
+  prefs->SetManagedPref(prefs::kCloudPrintProxyEnabled,
+                        base::MakeUnique<base::Value>(false));
 
   EXPECT_EQ(std::string(), prefs->GetString(prefs::kCloudPrintEmail));
 }
 
 TEST_F(CloudPrintProxyPolicyTest, StartWithNoPolicyProxyEnabledThenSetPolicy) {
   TestCloudPrintProxyService service(&profile_);
 
   service.GetMockServiceProcessControl()->SetConnectSuccessMockExpectations(
       MockServiceProcessControl::kServiceStateEnabled, false);
 
   sync_preferences::TestingPrefServiceSyncable* prefs =
       profile_.GetTestingPrefService();
-  prefs->SetUserPref(prefs::kCloudPrintEmail, new base::Value(std::string()));
+  prefs->SetUserPref(prefs::kCloudPrintEmail,
+                     base::MakeUnique<base::Value>(std::string()));
 
   service.Initialize();
   service.RefreshStatusFromService();
 
   EXPECT_EQ(MockServiceProcessControl::EnabledUserId(),
             prefs->GetString(prefs::kCloudPrintEmail));
 
   service.GetMockServiceProcessControl()->SetWillBeDisabledExpectations();
-  prefs->SetManagedPref(prefs::kCloudPrintProxyEnabled, new base::Value(false));
+  prefs->SetManagedPref(prefs::kCloudPrintProxyEnabled,
+                        base::MakeUnique<base::Value>(false));
 
   EXPECT_EQ(std::string(), prefs->GetString(prefs::kCloudPrintEmail));
 }
 
 TEST_F(CloudPrintProxyPolicyTest,
        StartWithPolicySetProxyDisabledThenClearPolicy) {
   TestCloudPrintProxyService service(&profile_);
 
   service.GetMockServiceProcessControl()->SetConnectSuccessMockExpectations(
       MockServiceProcessControl::kServiceStateDisabled, false);
 
   sync_preferences::TestingPrefServiceSyncable* prefs =
       profile_.GetTestingPrefService();
-  prefs->SetUserPref(prefs::kCloudPrintEmail, new base::Value(std::string()));
-  prefs->SetManagedPref(prefs::kCloudPrintProxyEnabled, new base::Value(false));
+  prefs->SetUserPref(prefs::kCloudPrintEmail,
+                     base::MakeUnique<base::Value>(std::string()));
+  prefs->SetManagedPref(prefs::kCloudPrintProxyEnabled,
+                        base::MakeUnique<base::Value>(false));
 
   service.Initialize();
 
   EXPECT_EQ(std::string(), prefs->GetString(prefs::kCloudPrintEmail));
   prefs->RemoveManagedPref(prefs::kCloudPrintProxyEnabled);
   EXPECT_EQ(std::string(), prefs->GetString(prefs::kCloudPrintEmail));
 }
 
 TEST_F(CloudPrintProxyPolicyTest,
        StartWithPolicySetProxyEnabledThenClearPolicy) {
   TestCloudPrintProxyService service(&profile_);
 
   service.GetMockServiceProcessControl()->SetConnectSuccessMockExpectations(
       MockServiceProcessControl::kServiceStateEnabled, false);
   service.GetMockServiceProcessControl()->SetWillBeDisabledExpectations();
 
   sync_preferences::TestingPrefServiceSyncable* prefs =
       profile_.GetTestingPrefService();
-  prefs->SetUserPref(prefs::kCloudPrintEmail, new base::Value(std::string()));
-  prefs->SetManagedPref(prefs::kCloudPrintProxyEnabled, new base::Value(false));
+  prefs->SetUserPref(prefs::kCloudPrintEmail,
+                     base::MakeUnique<base::Value>(std::string()));
+  prefs->SetManagedPref(prefs::kCloudPrintProxyEnabled,
+                        base::MakeUnique<base::Value>(false));
 
   service.Initialize();
 
   EXPECT_EQ(std::string(), prefs->GetString(prefs::kCloudPrintEmail));
   prefs->RemoveManagedPref(prefs::kCloudPrintProxyEnabled);
   EXPECT_EQ(std::string(), prefs->GetString(prefs::kCloudPrintEmail));
 }
 
 TEST_F(CloudPrintProxyPolicyTest, StartWithNoPolicyProxyDisabledThenEnable) {
   TestCloudPrintProxyService service(&profile_);
 
   service.GetMockServiceProcessControl()->SetConnectSuccessMockExpectations(
       MockServiceProcessControl::kServiceStateDisabled, false);
 
   sync_preferences::TestingPrefServiceSyncable* prefs =
       profile_.GetTestingPrefService();
-  prefs->SetUserPref(
-      prefs::kCloudPrintEmail,
-      new base::Value(MockServiceProcessControl::EnabledUserId()));
+  prefs->SetUserPref(prefs::kCloudPrintEmail,
+                     base::MakeUnique<base::Value>(
+                         MockServiceProcessControl::EnabledUserId()));
 
   service.Initialize();
   EXPECT_EQ(std::string(), prefs->GetString(prefs::kCloudPrintEmail));
 
   service.GetMockServiceProcessControl()->SetWillBeEnabledExpectations();
   service.EnableForUser();
 
   EXPECT_EQ(MockServiceProcessControl::EnabledUserId(),
             prefs->GetString(prefs::kCloudPrintEmail));
 }
 
 TEST_F(CloudPrintProxyPolicyTest,
        StartWithPolicySetProxyEnabledThenClearPolicyAndEnable) {
   TestCloudPrintProxyService service(&profile_);
 
   service.GetMockServiceProcessControl()->SetConnectSuccessMockExpectations(
       MockServiceProcessControl::kServiceStateEnabled, false);
   service.GetMockServiceProcessControl()->SetWillBeDisabledExpectations();
 
   sync_preferences::TestingPrefServiceSyncable* prefs =
       profile_.GetTestingPrefService();
-  prefs->SetUserPref(prefs::kCloudPrintEmail, new base::Value(std::string()));
-  prefs->SetManagedPref(prefs::kCloudPrintProxyEnabled, new base::Value(false));
+  prefs->SetUserPref(prefs::kCloudPrintEmail,
+                     base::MakeUnique<base::Value>(std::string()));
+  prefs->SetManagedPref(prefs::kCloudPrintProxyEnabled,
+                        base::MakeUnique<base::Value>(false));
 
   service.Initialize();
 
   EXPECT_EQ(std::string(), prefs->GetString(prefs::kCloudPrintEmail));
   service.EnableForUser();
   EXPECT_EQ(std::string(), prefs->GetString(prefs::kCloudPrintEmail));
 
   prefs->RemoveManagedPref(prefs::kCloudPrintProxyEnabled);
   EXPECT_EQ(std::string(), prefs->GetString(prefs::kCloudPrintEmail));
 
   service.GetMockServiceProcessControl()->SetWillBeEnabledExpectations();
   service.EnableForUser();
 
   EXPECT_EQ(MockServiceProcessControl::EnabledUserId(),
             prefs->GetString(prefs::kCloudPrintEmail));
 }