chrome/browser/chromeos/arc/arc_play_store_enabled_preference_handler_unittest.cc - Issue 2782553004: Move TestingPrefService to use unique_ptr<Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/arc/arc_play_store_enabled_preference_handler_unittest.cc

Issue 2782553004: Move TestingPrefService to use unique_ptr<Value> (Closed)

Patch Set: comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/bookmarks/managed_bookmark_service_unittest.cc ('k') | chrome/browser/chromeos/arc/arc_session_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/arc/arc_play_store_enabled_preference_handler_unittest.cc

diff --git a/chrome/browser/chromeos/arc/arc_play_store_enabled_preference_handler_unittest.cc b/chrome/browser/chromeos/arc/arc_play_store_enabled_preference_handler_unittest.cc

index a61f051038e3110ecbd734ed205d8df21503abc7..356a73e290640591e773433125cae182a20f5b71 100644

--- a/chrome/browser/chromeos/arc/arc_play_store_enabled_preference_handler_unittest.cc

+++ b/chrome/browser/chromeos/arc/arc_play_store_enabled_preference_handler_unittest.cc

@@ -136,8 +136,8 @@ TEST_F(ArcPlayStoreEnabledPreferenceHandlerTest,

TEST_F(ArcPlayStoreEnabledPreferenceHandlerTest, RemoveDataDir_Managed) {

// Set ARC to be managed and disabled.

- profile()->GetTestingPrefService()->SetManagedPref(prefs::kArcEnabled,

- new base::Value(false));

+ profile()->GetTestingPrefService()->SetManagedPref(

+ prefs::kArcEnabled, base::MakeUnique<base::Value>(false));

// Starting session manager with prefs::kArcEnabled off in a managed profile

// does automatically remove Android's data folder.