Move TestingPrefService to use unique_ptr<Value>

components/translate/core/browser/translate_prefs_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/translate/core/browser/translate_prefs.h"
 
 #include <algorithm>
 #include <string>
 #include <utility>
 #include <vector>
@@ skipping 222 matching lines @@
   int error_code = 0;
   std::string error_msg;
   int error_line = 0;
   int error_column = 0;
   std::unique_ptr<base::Value> profile(base::JSONReader::ReadAndReturnError(
       json1, 0, &error_code, &error_msg, &error_line, &error_column));
   ASSERT_EQ(0, error_code) << error_msg << " at " << error_line << ":"
                            << error_column << std::endl
                            << json1;
 
-  prefs_->SetUserPref(TranslatePrefs::kPrefLanguageProfile, profile.release());
+  prefs_->SetUserPref(TranslatePrefs::kPrefLanguageProfile, std::move(profile));
 
   TranslatePrefs::LanguageAndProbabilityList list;
   EXPECT_EQ(0.8, translate_prefs_->GetReadingFromUserLanguageProfile(&list));
   EXPECT_EQ(2UL, list.size());
   // the order in the ULP is wrong, and our code will sort it and make the
   // larger
   // one first.
   EXPECT_EQ("fr", list[0].first);
   EXPECT_EQ(0.6, list[0].second);
   EXPECT_EQ("en", list[1].first);  // the "en-AU" should be normalize to "en"
@@ skipping 27 matching lines @@
       "}";
 
   profile.reset(base::JSONReader::ReadAndReturnError(json2, 0, &error_code,
                                                      &error_msg, &error_line,
                                                      &error_column)
                     .release());
   ASSERT_EQ(0, error_code) << error_msg << " at " << error_line << ":"
                            << error_column << std::endl
                            << json2;
 
-  prefs_->SetUserPref(TranslatePrefs::kPrefLanguageProfile, profile.release());
+  prefs_->SetUserPref(TranslatePrefs::kPrefLanguageProfile, std::move(profile));
 
   list.clear();
   EXPECT_EQ(0.3, translate_prefs_->GetReadingFromUserLanguageProfile(&list));
   EXPECT_EQ(2UL, list.size());
   EXPECT_EQ("zh-TW", list[0].first);
   EXPECT_EQ(0.4, list[0].second);
   EXPECT_EQ("pt", list[1].first);  // the "pt-BR" should be normalize to "pt"
   EXPECT_EQ(0.1, list[1].second);
 
   // Case 3: Language Code normalization and reordering.
@@ skipping 16 matching lines @@
       "  }\n"
       "}";
   profile.reset(base::JSONReader::ReadAndReturnError(json3, 0, &error_code,
                                                      &error_msg, &error_line,
                                                      &error_column)
                     .release());
   ASSERT_EQ(0, error_code) << error_msg << " at " << error_line << ":"
                            << error_column << std::endl
                            << json3;
 
-  prefs_->SetUserPref(TranslatePrefs::kPrefLanguageProfile, profile.release());
+  prefs_->SetUserPref(TranslatePrefs::kPrefLanguageProfile, std::move(profile));
 
   list.clear();
   EXPECT_EQ(0.8, translate_prefs_->GetReadingFromUserLanguageProfile(&list));
   EXPECT_EQ(2UL, list.size());
   EXPECT_EQ("en", list[0].first);  // en-US and en-GB will be normalize into en
   EXPECT_EQ(0.6,
             list[0].second);  // and their probability will add to gether be 0.6
   EXPECT_EQ("fr", list[1].first);  // fr will move down to the 2nd one
   EXPECT_EQ(0.4, list[1].second);
 }
 
 }  // namespace translate