Move TestingPrefService to use unique_ptr<Value>

chrome/browser/chromeos/proxy_config_service_impl_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromeos/network/proxy/proxy_config_service_impl.h"
 
 #include <stddef.h>
 
 #include <utility>
 #include <vector>
 
 #include "base/format_macros.h"
 #include "base/json/json_writer.h"
 #include "base/logging.h"
 #include "base/macros.h"
+#include "base/memory/ptr_util.h"
 #include "base/message_loop/message_loop.h"
 #include "base/run_loop.h"
 #include "base/strings/stringprintf.h"
 #include "chrome/browser/chromeos/settings/cros_settings.h"
 #include "chrome/browser/chromeos/settings/device_settings_service.h"
 #include "chromeos/dbus/dbus_thread_manager.h"
 #include "chromeos/dbus/shill_profile_client.h"
 #include "chromeos/dbus/shill_service_client.h"
 #include "chromeos/network/network_handler.h"
 #include "chromeos/network/network_profile_handler.h"
@@ skipping 421 matching lines @@
     InitConfigWithTestInput(managed_params.input, &managed_config);
     base::DictionaryValue recommended_config;
     InitConfigWithTestInput(recommended_params.input, &recommended_config);
     base::DictionaryValue network_config;
     InitConfigWithTestInput(network_params.input, &network_config);
 
     // Managed proxy pref should take effect over recommended proxy and
     // non-existent network proxy.
     SetUserConfigInShill(nullptr);
     pref_service_.SetManagedPref(::proxy_config::prefs::kProxy,
-                                 managed_config.DeepCopy());
+                                 managed_config.CreateDeepCopy());
     pref_service_.SetRecommendedPref(::proxy_config::prefs::kProxy,
-                                     recommended_config.DeepCopy());
+                                     recommended_config.CreateDeepCopy());
     net::ProxyConfig actual_config;
     SyncGetLatestProxyConfig(&actual_config);
     EXPECT_EQ(managed_params.auto_detect, actual_config.auto_detect());
     EXPECT_EQ(managed_params.pac_url, actual_config.pac_url());
     EXPECT_TRUE(managed_params.proxy_rules.Matches(
         actual_config.proxy_rules()));
 
     // Recommended proxy pref should take effect when managed proxy pref is
     // removed.
     pref_service_.RemoveManagedPref(::proxy_config::prefs::kProxy);
     SyncGetLatestProxyConfig(&actual_config);
     EXPECT_EQ(recommended_params.auto_detect, actual_config.auto_detect());
     EXPECT_EQ(recommended_params.pac_url, actual_config.pac_url());
     EXPECT_TRUE(recommended_params.proxy_rules.Matches(
         actual_config.proxy_rules()));
 
     // Network proxy should take take effect over recommended proxy pref.
     SetUserConfigInShill(&network_config);
     SyncGetLatestProxyConfig(&actual_config);
     EXPECT_EQ(network_params.auto_detect, actual_config.auto_detect());
     EXPECT_EQ(network_params.pac_url, actual_config.pac_url());
     EXPECT_TRUE(network_params.proxy_rules.Matches(
         actual_config.proxy_rules()));
 
     // Managed proxy pref should take effect over network proxy.
     pref_service_.SetManagedPref(::proxy_config::prefs::kProxy,
-                                 managed_config.DeepCopy());
+                                 managed_config.CreateDeepCopy());
     SyncGetLatestProxyConfig(&actual_config);
     EXPECT_EQ(managed_params.auto_detect, actual_config.auto_detect());
     EXPECT_EQ(managed_params.pac_url, actual_config.pac_url());
     EXPECT_TRUE(managed_params.proxy_rules.Matches(
         actual_config.proxy_rules()));
 
     // Network proxy should take effect over recommended proxy pref when managed
     // proxy pref is removed.
     pref_service_.RemoveManagedPref(::proxy_config::prefs::kProxy);
     SyncGetLatestProxyConfig(&actual_config);
@@ skipping 19 matching lines @@
   SetUpSharedEthernet();
   SetUpProxyConfigService(&profile_prefs_);
 
   std::unique_ptr<base::DictionaryValue> ethernet_policy(
       chromeos::onc::ReadDictionaryFromJson(kEthernetPolicy));
 
   std::unique_ptr<base::ListValue> network_configs(new base::ListValue);
   network_configs->Append(std::move(ethernet_policy));
 
   profile_prefs_.SetUserPref(::proxy_config::prefs::kUseSharedProxies,
-                             new base::Value(false));
+                             base::MakeUnique<base::Value>(false));
   profile_prefs_.SetManagedPref(::onc::prefs::kOpenNetworkConfiguration,
-                                network_configs.release());
+                                std::move(network_configs));
 
   net::ProxyConfig actual_config;
   SyncGetLatestProxyConfig(&actual_config);
   net::ProxyConfig expected_config =
       net::ProxyConfig::CreateFromCustomPacURL(GURL("http://domain.com/x"));
   EXPECT_TRUE(expected_config.Equals(actual_config));
 }
 
 }  // namespace chromeos