chrome/browser/chromeos/arc/optin/arc_terms_of_service_default_negotiator_unittest.cc - Issue 2782553004: Move TestingPrefService to use unique_ptr<Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/arc/optin/arc_terms_of_service_default_negotiator_unittest.cc

Issue 2782553004: Move TestingPrefService to use unique_ptr<Value> (Closed)

Patch Set: comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/arc/arc_util_unittest.cc ('k') | chrome/browser/chromeos/policy/auto_enrollment_client_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/arc/optin/arc_terms_of_service_default_negotiator_unittest.cc

diff --git a/chrome/browser/chromeos/arc/optin/arc_terms_of_service_default_negotiator_unittest.cc b/chrome/browser/chromeos/arc/optin/arc_terms_of_service_default_negotiator_unittest.cc

index 78eb27f44d65f0286c963283926ab0d6590dbbde..56687cdff90bba1752cf181938497582ca2b8842 100644

--- a/chrome/browser/chromeos/arc/optin/arc_terms_of_service_default_negotiator_unittest.cc

+++ b/chrome/browser/chromeos/arc/optin/arc_terms_of_service_default_negotiator_unittest.cc

@@ -124,10 +124,10 @@ TEST_F(ArcTermsOfServiceDefaultNegotiatorTest, Accept) {

// The preferences are assigned to the managed false value, and the

// corresponding checkboxes are unchecked.

profile()->GetTestingPrefService()->SetManagedPref(

- prefs::kArcBackupRestoreEnabled, new base::Value(false));

+ prefs::kArcBackupRestoreEnabled, base::MakeUnique<base::Value>(false));

EXPECT_FALSE(fake_arc_support()->backup_and_restore_mode());

profile()->GetTestingPrefService()->SetManagedPref(

- prefs::kArcLocationServiceEnabled, new base::Value(false));

+ prefs::kArcLocationServiceEnabled, base::MakeUnique<base::Value>(false));

EXPECT_FALSE(fake_arc_support()->location_service_mode());

// The managed preference values are removed, and the corresponding checkboxes