components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_test_utils.cc - Issue 2782553004: Move TestingPrefService to use unique_ptr<Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_test_utils.cc

Issue 2782553004: Move TestingPrefService to use unique_ptr<Value> (Closed)

Patch Set: comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/cryptauth/cryptauth_enrollment_manager_unittest.cc ('k') | components/policy/core/browser/url_blacklist_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_test_utils.cc

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_test_utils.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_test_utils.cc

index 36bc1ece6f42d23e418fbfd6e3b686758849da5c..90476c4db2bda554e0ae9b86cf1038dc83b26998 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_test_utils.cc

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_test_utils.cc

@@ -124,7 +124,7 @@ void DataReductionProxySettingsTestBase::CheckOnPrefChange(

if (managed) {

test_context_->pref_service()->SetManagedPref(

test_context_->GetDataReductionProxyEnabledPrefName(),

- new base::Value(enabled));

+ base::MakeUnique<base::Value>(enabled));

} else {

test_context_->SetDataReductionProxyEnabled(enabled);

}