DevTools: split text_utils out of common module

DevTools: split text_utils out of common module

This patch introduces a new 'text_utils' module which has text-related
classes from 'common' module.

We always had a need to have text_utils in formatter worker, but since it
was part of a big 'common' module, re-implemented parts of it functionality
inside worker.

This is a pre-step to switching javascript outline from tokenizer to AST.
Generating AST with locations for every node is time-consuming; instead, we'd
like to simply re-use TextUtils.TextCursor.

BUG=438203
R=dgozman

Review-Url: https://codereview.chromium.org/2769843003
Cr-Commit-Position: refs/heads/master@{#459357}
Committed: https://chromium.googlesource.com/chromium/src/+/da678dd14198b5dee5303e9d51d1ff883b4a8e12

[lushnikov, 2017-03-22 21:56:04]

please, take a look

[lushnikov, 2017-03-22 21:58:24]

Description was changed from

==========
DevTools: split text_utils out of common module

This patch moves text-related files from common module so that they
can be reused in formatter_worker.

This makes sense since formatter worker is working with text. It was
re-implementing certain methods from TextUtils by itself, which caused
friction.

This is a pre-step to switching javascript outline from tokenizer to AST.
Generating AST with locations for every node is time-consuming; instead, we'd
like to simply re-use TextUtils.TextCursor.

BUG=438203
R=dgozman
==========

to

==========
DevTools: split text_utils out of common module

This patch introduces a new 'text_utils' module which has text-related
classes from 'common' module.

We always had a need to have text_utils in formatter worker, but since it
was part of a big 'common' module, re-implemented parts of it functionality
inside worker.

This is a pre-step to switching javascript outline from tokenizer to AST.
Generating AST with locations for every node is time-consuming; instead, we'd
like to simply re-use TextUtils.TextCursor.

BUG=438203
R=dgozman
==========

[lushnikov, 2017-03-22 21:58:31]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-22 21:59:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dgozman, 2017-03-22 22:54:12]

https://codereview.chromium.org/2769843003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/text_utils/Text.js (right):

https://codereview.chromium.org/2769843003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/text_utils/Text.js:5:
self['TextUtils'] = self['TextUtils'] || {};
Can we remove this line?

https://codereview.chromium.org/2769843003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/text_utils/module.json
(right):

https://codereview.chromium.org/2769843003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/text_utils/module.json:2:
"dependencies": [],
utilities!

[commit-bot: I haz the power, 2017-03-22 23:22:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 23:22:07]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[lushnikov, 2017-03-23 00:50:50]

all done

https://codereview.chromium.org/2769843003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/text_utils/Text.js (right):

https://codereview.chromium.org/2769843003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/text_utils/Text.js:5:
self['TextUtils'] = self['TextUtils'] || {};
On 2017/03/22 22:54:12, dgozman wrote:
> Can we remove this line?

Done.

https://codereview.chromium.org/2769843003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/text_utils/module.json
(right):

https://codereview.chromium.org/2769843003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/text_utils/module.json:2:
"dependencies": [],
On 2017/03/22 22:54:12, dgozman wrote:
> utilities!

Done.

[lushnikov, 2017-03-23 00:50:58]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-23 00:51:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 00:56:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 00:56:20]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[dgozman, 2017-03-23 21:50:12]

lgtm

[lushnikov, 2017-03-23 22:50:36]

The CQ bit was checked by lushnikov@chromium.org

[lushnikov, 2017-03-23 22:50:37]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2769843003/#ps40001
(title: "rebaseline")

[commit-bot: I haz the power, 2017-03-23 22:51:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 00:27:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 00:27:51]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[lushnikov, 2017-03-24 01:10:04]

The CQ bit was checked by lushnikov@chromium.org

[lushnikov, 2017-03-24 01:10:05]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2769843003/#ps60001
(title: "rebaseline")

[commit-bot: I haz the power, 2017-03-24 01:10:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lushnikov, 2017-03-24 04:03:14]

The CQ bit was unchecked by lushnikov@chromium.org

[lushnikov, 2017-03-24 04:03:14]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2017-03-24 04:04:34]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1490317804719990,
"parent_rev": "54548ddbe9febbe12dafb3178811a0c86b0636f7", "commit_rev":
"da678dd14198b5dee5303e9d51d1ff883b4a8e12"}

[commit-bot: I haz the power, 2017-03-24 04:05:24]

Description was changed from

==========
DevTools: split text_utils out of common module

This patch introduces a new 'text_utils' module which has text-related
classes from 'common' module.

We always had a need to have text_utils in formatter worker, but since it
was part of a big 'common' module, re-implemented parts of it functionality
inside worker.

This is a pre-step to switching javascript outline from tokenizer to AST.
Generating AST with locations for every node is time-consuming; instead, we'd
like to simply re-use TextUtils.TextCursor.

BUG=438203
R=dgozman
==========

to

==========
DevTools: split text_utils out of common module

This patch introduces a new 'text_utils' module which has text-related
classes from 'common' module.

We always had a need to have text_utils in formatter worker, but since it
was part of a big 'common' module, re-implemented parts of it functionality
inside worker.

This is a pre-step to switching javascript outline from tokenizer to AST.
Generating AST with locations for every node is time-consuming; instead, we'd
like to simply re-use TextUtils.TextCursor.

BUG=438203
R=dgozman

Review-Url: https://codereview.chromium.org/2769843003
Cr-Commit-Position: refs/heads/master@{#459357}
Committed:
https://chromium.googlesource.com/chromium/src/+/da678dd14198b5dee5303e9d51d1...
==========

[commit-bot: I haz the power, 2017-03-24 04:05:26]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/da678dd14198b5dee5303e9d51d1...