third_party/WebKit/Source/devtools/front_end/sources/EditingLocationHistoryManager.js - Issue 2769843003: DevTools: split text_utils out of common module

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/EditingLocationHistoryManager.js

Issue 2769843003: DevTools: split text_utils out of common module (Closed)

Patch Set: rebaseline Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sources/CSSSourceFrame.js ('k') | third_party/WebKit/Source/devtools/front_end/sources/FileBasedSearchResultsPane.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sources/EditingLocationHistoryManager.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sources/EditingLocationHistoryManager.js b/third_party/WebKit/Source/devtools/front_end/sources/EditingLocationHistoryManager.js

index afd3d4d56b4fd203443a4c47b4e41f21aa5530ce..f374d868618db63e17af3c9d88076cf43b201930 100644

--- a/third_party/WebKit/Source/devtools/front_end/sources/EditingLocationHistoryManager.js

+++ b/third_party/WebKit/Source/devtools/front_end/sources/EditingLocationHistoryManager.js

@@ -83,7 +83,7 @@ Sources.EditingLocationHistoryManager = class {

}

/**

- * @param {!Common.TextRange} selection

+ * @param {!TextUtils.TextRange} selection

_updateActiveState(selection) {

var active = this._historyManager.active();

@@ -97,7 +97,7 @@ Sources.EditingLocationHistoryManager = class {

}

/**

- * @param {!Common.TextRange} selection

+ * @param {!TextUtils.TextRange} selection

_pushActiveState(selection) {

var sourceFrame = this._currentSourceFrameCallback();

@@ -130,7 +130,7 @@ Sources.EditingLocationHistoryEntry = class {

* @param {!Sources.SourcesView} sourcesView

* @param {!Sources.EditingLocationHistoryManager} editingLocationManager

* @param {!SourceFrame.SourceFrame} sourceFrame

- * @param {!Common.TextRange} selection

+ * @param {!TextUtils.TextRange} selection

constructor(sourcesView, editingLocationManager, sourceFrame, selection) {

this._sourcesView = sourcesView;

@@ -153,7 +153,7 @@ Sources.EditingLocationHistoryEntry = class {

}

/**

- * @param {!Common.TextRange} selection

+ * @param {!TextUtils.TextRange} selection

* @return {!{lineNumber: number, columnNumber: number}}

_positionFromSelection(selection) {