Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(767)

Unified Diff: third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js

Issue 2769843003: DevTools: split text_utils out of common module (Closed)
Patch Set: rebaseline Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js
diff --git a/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js b/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js
index 3323be720e1b4efda66648d1bbdf03828c03d3bb..9b59efd2c9a260011886115918bcf3c93fdb7527 100644
--- a/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js
+++ b/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js
@@ -425,7 +425,7 @@ Elements.StylesSidebarPane = class extends Elements.ElementsSidebarPane {
function onStyleSheetContent(styleSheetId, text) {
text = text || '';
var lines = text.split('\n');
- var range = Common.TextRange.createFromLocation(lines.length - 1, lines[lines.length - 1].length);
+ var range = TextUtils.TextRange.createFromLocation(lines.length - 1, lines[lines.length - 1].length);
this._addBlankSection(this._sectionBlocks[0].sections[0], styleSheetId, range);
}
}
@@ -433,7 +433,7 @@ Elements.StylesSidebarPane = class extends Elements.ElementsSidebarPane {
/**
* @param {!Elements.StylePropertiesSection} insertAfterSection
* @param {string} styleSheetId
- * @param {!Common.TextRange} ruleLocation
+ * @param {!TextUtils.TextRange} ruleLocation
*/
_addBlankSection(insertAfterSection, styleSheetId, ruleLocation) {
var node = this.node();
@@ -693,7 +693,7 @@ Elements.StylePropertiesSection = class {
* @param {!SDK.CSSModel} cssModel
* @param {!Components.Linkifier} linkifier
* @param {string} styleSheetId
- * @param {!Common.TextRange} ruleLocation
+ * @param {!TextUtils.TextRange} ruleLocation
* @return {!Node}
*/
static _linkifyRuleLocation(cssModel, linkifier, styleSheetId, ruleLocation) {
@@ -898,7 +898,7 @@ Elements.StylePropertiesSection = class {
_onNewRuleClick(event) {
event.data.consume();
var rule = this._style.parentRule;
- var range = Common.TextRange.createFromLocation(rule.style.range.endLine, rule.style.range.endColumn + 1);
+ var range = TextUtils.TextRange.createFromLocation(rule.style.range.endLine, rule.style.range.endColumn + 1);
this._parentPane._addBlankSection(this, /** @type {string} */ (rule.styleSheetId), range);
}
@@ -1563,7 +1563,7 @@ Elements.BlankStylePropertiesSection = class extends Elements.StylePropertiesSec
* @param {!SDK.CSSMatchedStyles} matchedStyles
* @param {string} defaultSelectorText
* @param {string} styleSheetId
- * @param {!Common.TextRange} ruleLocation
+ * @param {!TextUtils.TextRange} ruleLocation
* @param {!SDK.CSSStyleDeclaration} insertAfterStyle
*/
constructor(stylesPane, matchedStyles, defaultSelectorText, styleSheetId, ruleLocation, insertAfterStyle) {
@@ -1582,13 +1582,13 @@ Elements.BlankStylePropertiesSection = class extends Elements.StylePropertiesSec
}
/**
- * @return {!Common.TextRange}
+ * @return {!TextUtils.TextRange}
*/
_actualRuleLocation() {
var prefix = this._rulePrefix();
var lines = prefix.split('\n');
- var editRange = new Common.TextRange(0, 0, lines.length - 1, lines.peekLast().length);
- return this._ruleLocation.rebaseAfterTextEdit(Common.TextRange.createFromLocation(0, 0), editRange);
+ var editRange = new TextUtils.TextRange(0, 0, lines.length - 1, lines.peekLast().length);
+ return this._ruleLocation.rebaseAfterTextEdit(TextUtils.TextRange.createFromLocation(0, 0), editRange);
}
/**
@@ -3020,7 +3020,7 @@ Elements.StylesSidebarPropertyRenderer = class {
regexes.push(Common.Color.Regex);
processors.push(this._colorHandler);
}
- var results = Common.TextUtils.splitStringByRegexes(this._propertyValue, regexes);
+ var results = TextUtils.TextUtils.splitStringByRegexes(this._propertyValue, regexes);
for (var i = 0; i < results.length; i++) {
var result = results[i];
var processor = result.regexIndex === -1 ? createTextNode : processors[result.regexIndex];

Powered by Google App Engine
This is Rietveld 408576698