Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(674)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/TabbedEditorContainer.js

Issue 2769843003: DevTools: split text_utils out of common module (Closed)
Patch Set: rebaseline Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sources/TabbedEditorContainer.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sources/TabbedEditorContainer.js b/third_party/WebKit/Source/devtools/front_end/sources/TabbedEditorContainer.js
index af1160fb2cd19c202d050c754339b2f9a0ff02b1..051eaad8139ae2b7cfc6808d0ac50f0cab20d6ac 100644
--- a/third_party/WebKit/Source/devtools/front_end/sources/TabbedEditorContainer.js
+++ b/third_party/WebKit/Source/devtools/front_end/sources/TabbedEditorContainer.js
@@ -237,7 +237,7 @@ Sources.TabbedEditorContainer = class extends Common.Object {
* @param {!Common.Event} event
*/
_selectionChanged(event) {
- var range = /** @type {!Common.TextRange} */ (event.data);
+ var range = /** @type {!TextUtils.TextRange} */ (event.data);
this._history.updateSelectionRange(this._currentFile.url(), range);
this._history.save(this._previouslyViewedFilesSetting);
}
@@ -453,7 +453,7 @@ Sources.TabbedEditorContainer = class extends Common.Object {
/**
* @param {!UI.Widget} editorView
- * @param {!Common.TextRange=} selection
+ * @param {!TextUtils.TextRange=} selection
* @param {number=} firstLineNumber
*/
_restoreEditorProperties(editorView, selection, firstLineNumber) {
@@ -599,7 +599,7 @@ Sources.TabbedEditorContainer.maximalPreviouslyViewedFilesCount = 30;
Sources.TabbedEditorContainer.HistoryItem = class {
/**
* @param {string} url
- * @param {!Common.TextRange=} selectionRange
+ * @param {!TextUtils.TextRange=} selectionRange
* @param {number=} scrollLineNumber
*/
constructor(url, selectionRange, scrollLineNumber) {
@@ -616,7 +616,7 @@ Sources.TabbedEditorContainer.HistoryItem = class {
*/
static fromObject(serializedHistoryItem) {
var selectionRange = serializedHistoryItem.selectionRange ?
- Common.TextRange.fromObject(serializedHistoryItem.selectionRange) :
+ TextUtils.TextRange.fromObject(serializedHistoryItem.selectionRange) :
undefined;
return new Sources.TabbedEditorContainer.HistoryItem(
serializedHistoryItem.url, selectionRange, serializedHistoryItem.scrollLineNumber);
@@ -681,7 +681,7 @@ Sources.TabbedEditorContainer.History = class {
/**
* @param {string} url
- * @return {!Common.TextRange|undefined}
+ * @return {!TextUtils.TextRange|undefined}
*/
selectionRange(url) {
var index = this.index(url);
@@ -690,7 +690,7 @@ Sources.TabbedEditorContainer.History = class {
/**
* @param {string} url
- * @param {!Common.TextRange=} selectionRange
+ * @param {!TextUtils.TextRange=} selectionRange
*/
updateSelectionRange(url, selectionRange) {
if (!selectionRange)

Powered by Google App Engine
This is Rietveld 408576698