third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js - Issue 2769843003: DevTools: split text_utils out of common module

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js

Issue 2769843003: DevTools: split text_utils out of common module (Closed)

Patch Set: rebaseline Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/coverage/CoverageModel.js ('k') | third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js

diff --git a/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js b/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js

index d5492c6ad3d960b075018923be879930be00870b..929774546621cce369abc3e854ecb2fbc9799c2b 100644

--- a/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js

+++ b/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js

@@ -1343,7 +1343,7 @@ Elements.ElementsTreeElement = class extends UI.TreeElement {

/**

* @param {string} text

- * @return {!{text: string, entityRanges: !Array.<!Common.SourceRange>}}

+ * @return {!{text: string, entityRanges: !Array.<!TextUtils.SourceRange>}}

_convertWhitespaceToEntities(text) {

var result = '';

@@ -1565,13 +1565,13 @@ Elements.ElementsTreeElement = class extends UI.TreeElement {

var match = regexObject.exec(text);

var matchRanges = [];

while (match) {

- matchRanges.push(new Common.SourceRange(match.index, match[0].length));

+ matchRanges.push(new TextUtils.SourceRange(match.index, match[0].length));

match = regexObject.exec(text);

}

// Fall back for XPath, etc. matches.

if (!matchRanges.length)

- matchRanges.push(new Common.SourceRange(0, text.length));

+ matchRanges.push(new TextUtils.SourceRange(0, text.length));

this._highlightResult = [];

UI.highlightSearchResults(this.listItemElement, matchRanges, this._highlightResult);