Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(902)

Unified Diff: third_party/WebKit/Source/devtools/front_end/text_editor/TextEditorAutocompleteController.js

Issue 2769843003: DevTools: split text_utils out of common module (Closed)
Patch Set: rebaseline Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/text_editor/TextEditorAutocompleteController.js
diff --git a/third_party/WebKit/Source/devtools/front_end/text_editor/TextEditorAutocompleteController.js b/third_party/WebKit/Source/devtools/front_end/text_editor/TextEditorAutocompleteController.js
index 7f508b465491f994f71217f6d2ba9c06ff0cdeae..fc0be056d313ebad00881c5b81d01a3309c37b93 100644
--- a/third_party/WebKit/Source/devtools/front_end/text_editor/TextEditorAutocompleteController.js
+++ b/third_party/WebKit/Source/devtools/front_end/text_editor/TextEditorAutocompleteController.js
@@ -71,7 +71,7 @@ TextEditor.TextEditorAutocompleteController = class {
* @param {string} text
*/
_addWordsFromText(text) {
- Common.TextUtils.textToWords(
+ TextUtils.TextUtils.textToWords(
text, /** @type {function(string):boolean} */ (this._config.isWordChar), addWord.bind(this));
/**
@@ -88,7 +88,7 @@ TextEditor.TextEditorAutocompleteController = class {
* @param {string} text
*/
_removeWordsFromText(text) {
- Common.TextUtils.textToWords(
+ TextUtils.TextUtils.textToWords(
text, /** @type {function(string):boolean} */ (this._config.isWordChar),
word => this._dictionary.removeWord(word));
}
@@ -96,7 +96,7 @@ TextEditor.TextEditorAutocompleteController = class {
/**
* @param {number} lineNumber
* @param {number} columnNumber
- * @return {?Common.TextRange}
+ * @return {?TextUtils.TextRange}
*/
_substituteRange(lineNumber, columnNumber) {
var range =
@@ -107,8 +107,8 @@ TextEditor.TextEditorAutocompleteController = class {
}
/**
- * @param {!Common.TextRange} queryRange
- * @param {!Common.TextRange} substituteRange
+ * @param {!TextUtils.TextRange} queryRange
+ * @param {!TextUtils.TextRange} substituteRange
* @param {boolean=} force
* @return {!Promise.<!UI.SuggestBox.Suggestions>}
*/
@@ -191,7 +191,7 @@ TextEditor.TextEditorAutocompleteController = class {
}
/**
- * @param {!Common.TextRange} mainSelection
+ * @param {!TextUtils.TextRange} mainSelection
* @return {boolean}
*/
_validateSelectionsContexts(mainSelection) {
@@ -275,7 +275,7 @@ TextEditor.TextEditorAutocompleteController = class {
var cursor = this._codeMirror.getCursor('to');
if (this._hintMarker) {
var position = this._hintMarker.position();
- if (!position || !position.equal(Common.TextRange.createFromLocation(cursor.line, cursor.ch))) {
+ if (!position || !position.equal(TextUtils.TextRange.createFromLocation(cursor.line, cursor.ch))) {
this._hintMarker.clear();
this._hintMarker = null;
}

Powered by Google App Engine
This is Rietveld 408576698