third_party/WebKit/Source/devtools/front_end/quick_open/FilteredListWidget.js - Issue 2769843003: DevTools: split text_utils out of common module

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/quick_open/FilteredListWidget.js

Issue 2769843003: DevTools: split text_utils out of common module (Closed)

Patch Set: rebaseline Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/object_ui/ObjectPropertiesSection.js ('k') | third_party/WebKit/Source/devtools/front_end/sass/ASTSourceMap.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/quick_open/FilteredListWidget.js

diff --git a/third_party/WebKit/Source/devtools/front_end/quick_open/FilteredListWidget.js b/third_party/WebKit/Source/devtools/front_end/quick_open/FilteredListWidget.js

index 08bba4e7c70f8c30643a3a505d5069232b41b48c..a6073ec5599bf34755f95ad02a1a9d3e8c3af879 100644

--- a/third_party/WebKit/Source/devtools/front_end/quick_open/FilteredListWidget.js

+++ b/third_party/WebKit/Source/devtools/front_end/quick_open/FilteredListWidget.js

@@ -79,7 +79,7 @@ QuickOpen.FilteredListWidget = class extends UI.VBox {

/**

* @param {string} text

* @param {string} query

- * @return {?Array.<!Common.SourceRange>}

+ * @return {?Array.<!TextUtils.SourceRange>}

function rangesForMatch(text, query) {

var opcodes = Diff.Diff.charDiff(query, text);

@@ -88,7 +88,7 @@ QuickOpen.FilteredListWidget = class extends UI.VBox {

for (var i = 0; i < opcodes.length; ++i) {

var opcode = opcodes[i];

if (opcode[0] === Diff.Diff.Operation.Equal)

- ranges.push(new Common.SourceRange(offset, opcode[1].length));

+ ranges.push(new TextUtils.SourceRange(offset, opcode[1].length));

else if (opcode[0] !== Diff.Diff.Operation.Insert)

return null;

offset += opcode[1].length;