Rename MediaClientAndroid to MediaDrmBridgeClient

Rename MediaClientAndroid to MediaDrmBridgeClient

MediaClient and MediaClientAndroid (now MediaDrmBridgeClient)
are distict interfaces. The previous naming wrongly suggests that
MediaClientAndroid is the Android implementation of MediaClient.

BUG=695264
Review-Url: https://codereview.chromium.org/2756333002
Cr-Commit-Position: refs/heads/master@{#458783}
Committed: https://chromium.googlesource.com/chromium/src/+/a4a8efbb8b68c2a61636fc469943ecb1d09bd84b

[chcunningham, 2017-03-17 23:45:37]

chcunningham@chromium.org changed reviewers:
+ jrummell@chromium.org

[chcunningham, 2017-03-17 23:45:37]

Hey John,

This name has been bugging me for a while. Let me know if you'd support a rename
and I'll add in the cast folks.

[jrummell, 2017-03-18 00:43:10]

jrummell@chromium.org changed reviewers:
+ xhwang@chromium.org

[jrummell, 2017-03-18 00:43:11]

I have no problem with the name change. Adding xhwang@ in case he has an
opinion.

[xhwang, 2017-03-18 00:48:17]

I agree the original naming is confusing.

How about MediaDrmBridgeClient to make this even more explicit?

[xhwang, 2017-03-18 00:48:30]

BTW, thanks for fixing this!!!

[chcunningham, 2017-03-18 01:45:08]

The CQ bit was checked by chcunningham@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-18 01:45:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chcunningham, 2017-03-18 01:45:51]

On 2017/03/18 00:48:30, xhwang_slow wrote:
> BTW, thanks for fixing this!!!

On 2017/03/18 00:48:17, xhwang_slow wrote:
> I agree the original naming is confusing.
> 
> How about MediaDrmBridgeClient to make this even more explicit?

Done.

On 2017/03/18 00:48:30, xhwang_slow wrote:
> BTW, thanks for fixing this!!!

You bet!

[commit-bot: I haz the power, 2017-03-18 02:13:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-18 02:13:25]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[xhwang, 2017-03-18 04:02:00]

Please update the CL title to reflect the new name. Also it seems some bots are
broken.

Otherwise, LGTM! Thank you again!

[halliwell, 2017-03-18 04:13:35]

On 2017/03/18 04:02:00, xhwang_slow wrote:
> Please update the CL title to reflect the new name. Also it seems some bots
are
> broken.
> 
> Otherwise, LGTM! Thank you again!

chromecast/ lgtm

[xhwang, 2017-03-18 05:04:28]

https://codereview.chromium.org/2756333002/diff/20001/media/base/android/medi...
File media/base/android/media_drm_bridge_client.cc (right):

https://codereview.chromium.org/2756333002/diff/20001/media/base/android/medi...
media/base/android/media_drm_bridge_client.cc:12: static MediaDrmBridgeClient*
g_media_client = nullptr;
please also s/media_client/media_drm_bridge_client/ in this file to avoid
confusion.

[chcunningham, 2017-03-20 18:32:33]

Description was changed from

==========
Rename MediaClientAndroid to AndroidMediaDrmClient

MediaClient and MediaClientAndroid (now AndroidMediaDrmClient)
are distict interfaces. The previous naming wrongly suggests that
MediaClientAndroid is the Android implementation of MediaClient.

BUG=695264
==========

to

==========
Rename MediaClientAndroid to MediaDrmBridgeClient

MediaClient and MediaClientAndroid (now MediaDrmBridgeClient)
are distict interfaces. The previous naming wrongly suggests that
MediaClientAndroid is the Android implementation of MediaClient.

BUG=695264
==========

[chcunningham, 2017-03-20 18:52:31]

The CQ bit was checked by chcunningham@chromium.org to run a CQ dry run

[chcunningham, 2017-03-20 18:53:08]

Thanks guys.

https://codereview.chromium.org/2756333002/diff/20001/media/base/android/medi...
File media/base/android/media_drm_bridge_client.cc (right):

https://codereview.chromium.org/2756333002/diff/20001/media/base/android/medi...
media/base/android/media_drm_bridge_client.cc:12: static MediaDrmBridgeClient*
g_media_client = nullptr;
On 2017/03/18 05:04:28, xhwang_slow wrote:
> please also s/media_client/media_drm_bridge_client/ in this file to avoid
> confusion.

Done.

[commit-bot: I haz the power, 2017-03-20 18:53:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chcunningham, 2017-03-20 18:56:23]

chcunningham@chromium.org changed reviewers:
+ creis@chromium.org

[chcunningham, 2017-03-20 18:56:23]

creis@chromium.org for content

[commit-bot: I haz the power, 2017-03-20 19:19:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-20 19:19:50]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[chcunningham, 2017-03-20 21:30:53]

The CQ bit was checked by chcunningham@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-20 21:31:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 01:37:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 01:37:30]

Dry run: This issue passed the CQ dry run.

[Charlie Reis, 2017-03-21 16:16:30]

content/ LGTM

[chcunningham, 2017-03-21 17:15:55]

The CQ bit was checked by chcunningham@chromium.org

[chcunningham, 2017-03-21 17:15:56]

The patchset sent to the CQ was uploaded after l-g-t-m from xhwang@chromium.org,
halliwell@chromium.org
Link to the patchset: https://codereview.chromium.org/2756333002/#ps40001
(title: "Feedback and Rebase")

[commit-bot: I haz the power, 2017-03-21 17:16:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 17:27:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 17:27:29]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[chcunningham, 2017-03-21 18:04:00]

chcunningham@chromium.org changed reviewers:
+ boliu@chromium.org, jochen@chromium.org

[chcunningham, 2017-03-21 18:04:01]

+boliu for webview
+jochen for chrome

[boliu, 2017-03-21 18:09:10]

https://codereview.chromium.org/2756333002/diff/40001/android_webview/common/...
File android_webview/common/aw_media_drm_bridge_client.h (right):

https://codereview.chromium.org/2756333002/diff/40001/android_webview/common/...
android_webview/common/aw_media_drm_bridge_client.h:5: #ifndef
ANDROID_WEBVIEW_COMMON_AW_MEDIA_CLIENT_ANDROID_H_
fix ifdef guard

https://codereview.chromium.org/2756333002/diff/40001/media/base/android/medi...
File media/base/android/media_drm_bridge_client.h (right):

https://codereview.chromium.org/2756333002/diff/40001/media/base/android/medi...
media/base/android/media_drm_bridge_client.h:5: #ifndef
MEDIA_BASE_ANDROID_media_drm_bridge_client_H_
ifdef guard should be all caps

[chcunningham, 2017-03-21 22:18:16]

https://codereview.chromium.org/2756333002/diff/40001/android_webview/common/...
File android_webview/common/aw_media_drm_bridge_client.h (right):

https://codereview.chromium.org/2756333002/diff/40001/android_webview/common/...
android_webview/common/aw_media_drm_bridge_client.h:5: #ifndef
ANDROID_WEBVIEW_COMMON_AW_MEDIA_CLIENT_ANDROID_H_
On 2017/03/21 18:09:10, boliu wrote:
> fix ifdef guard

Done.

https://codereview.chromium.org/2756333002/diff/40001/media/base/android/medi...
File media/base/android/media_drm_bridge_client.h (right):

https://codereview.chromium.org/2756333002/diff/40001/media/base/android/medi...
media/base/android/media_drm_bridge_client.h:5: #ifndef
MEDIA_BASE_ANDROID_media_drm_bridge_client_H_
On 2017/03/21 18:09:10, boliu wrote:
> ifdef guard should be all caps

Done.

[chcunningham, 2017-03-21 22:21:36]

The CQ bit was checked by chcunningham@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-21 22:22:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[boliu, 2017-03-21 22:26:11]

lgtm

[commit-bot: I haz the power, 2017-03-22 00:46:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 00:46:15]

Dry run: This issue passed the CQ dry run.

[jochen (gone - plz use gerrit), 2017-03-22 10:06:38]

jochen@chromium.org changed reviewers:
+ halliwell@chromium.org

[jochen (gone - plz use gerrit), 2017-03-22 10:06:38]

chrome/ lgtm

[chcunningham, 2017-03-22 16:41:35]

The CQ bit was checked by chcunningham@chromium.org

[chcunningham, 2017-03-22 16:41:35]

The patchset sent to the CQ was uploaded after l-g-t-m from
halliwell@chromium.org, creis@chromium.org, xhwang@chromium.org
Link to the patchset: https://codereview.chromium.org/2756333002/#ps60001
(title: "Fix .h guards")

[commit-bot: I haz the power, 2017-03-22 16:41:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 16:55:07]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1490200895244850,
"parent_rev": "ac2f201c499c2d65a5d43b6ce49d9af5b4520f99", "commit_rev":
"a4a8efbb8b68c2a61636fc469943ecb1d09bd84b"}

[commit-bot: I haz the power, 2017-03-22 17:00:13]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1490200895244850,
"parent_rev": "ac2f201c499c2d65a5d43b6ce49d9af5b4520f99", "commit_rev":
"a4a8efbb8b68c2a61636fc469943ecb1d09bd84b"}

[commit-bot: I haz the power, 2017-03-22 17:00:38]

Description was changed from

==========
Rename MediaClientAndroid to MediaDrmBridgeClient

MediaClient and MediaClientAndroid (now MediaDrmBridgeClient)
are distict interfaces. The previous naming wrongly suggests that
MediaClientAndroid is the Android implementation of MediaClient.

BUG=695264
==========

to

==========
Rename MediaClientAndroid to MediaDrmBridgeClient

MediaClient and MediaClientAndroid (now MediaDrmBridgeClient)
are distict interfaces. The previous naming wrongly suggests that
MediaClientAndroid is the Android implementation of MediaClient.

BUG=695264

Review-Url: https://codereview.chromium.org/2756333002
Cr-Commit-Position: refs/heads/master@{#458783}
Committed:
https://chromium.googlesource.com/chromium/src/+/a4a8efbb8b68c2a61636fc469943...
==========

[commit-bot: I haz the power, 2017-03-22 17:00:40]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/a4a8efbb8b68c2a61636fc469943...