Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(7)

Issue 2754273003: Introduce restricted PasswordFormManager::GrabFetcher (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months, 1 week ago by vabr (Chromium)
Modified:
3 months ago
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Introduce restricted PasswordFormManager::GrabFetcher This CL introduces a version of PasswordFormManager::GrabFetcher where the attached FormFetcher must be the same which was already associated to the PasswordFormManager. The CL also uses that new method to get rid of the redundant CredentialManagerPasswordFormManager::form_fetcher_ in favour of PasswordFormManager::owned_form_fetcher_. While ultimately the restriction on GrabFetcher will be lifted in https://codereview.chromium.org/2758773002/, the restricted form of GrabFetcher is a pre-requisite for ensuring the correct lifetime of the owned FormFetcher in CredentialManagerPasswordFormManager in https://codereview.chromium.org/2760653002/, which itself is a pre-requisite of the unrestricted version of GrabFetcher. See https://docs.google.com/document/d/12CH_SV1gIJKaEIGTs7gWBiXrCMlBa3o32OyC2LRtPAo/edit#heading=h.jz2q52kebs7k for more details. BUG=621355 Review-Url: https://codereview.chromium.org/2754273003 Cr-Commit-Position: refs/heads/master@{#458157} Committed: https://chromium.googlesource.com/chromium/src/+/1506f35e2a82f1b50ba2aa51e61c60891dc8cbcc

Patch Set 1 #

Patch Set 2 : Introduce restricted PasswordFormManager::GrabFetcher #

Patch Set 3 : Fix compilation #

Patch Set 4 : Remove redundant CredentialManagerPasswordFormManager::form_fetcher_ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -9 lines) Patch
M components/password_manager/core/browser/credential_manager_password_form_manager.h View 1 2 3 1 chunk +0 lines, -5 lines 0 comments Download
M components/password_manager/core/browser/credential_manager_password_form_manager.cc View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M components/password_manager/core/browser/password_form_manager.h View 2 chunks +6 lines, -1 line 0 comments Download
M components/password_manager/core/browser/password_form_manager.cc View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M components/password_manager/core/browser/password_form_manager_unittest.cc View 1 2 2 chunks +19 lines, -0 lines 0 comments Download
Trybot results:  chromeos_amd64-generic_chromium_compile_only_ng   win_chromium_x64_rel_ng   mac_chromium_rel_ng   win_clang   win_chromium_rel_ng   win_chromium_compile_dbg_ng   mac_chromium_compile_dbg_ng   cast_shell_android   android_compile_dbg   chromium_presubmit   linux_chromium_rel_ng   linux_chromium_chromeos_rel_ng   linux_chromium_tsan_rel_ng   ios-device-xcode-clang   chromeos_amd64-generic_chromium_compile_only_ng   linux_android_rel_ng   linux_chromium_chromeos_ozone_rel_ng   android_cronet   android_arm64_dbg_recipe   linux_chromium_asan_rel_ng   ios-simulator   ios-simulator-xcode-clang   ios-device   android_clang_dbg_recipe   linux_chromium_compile_dbg_ng   chromeos_daisy_chromium_compile_only_ng   android_n5x_swarming_rel   cast_shell_linux   win_chromium_rel_ng   win_chromium_x64_rel_ng   win_clang   cast_shell_android   ios-simulator   linux_chromium_chromeos_ozone_rel_ng   cast_shell_linux   ios-device-xcode-clang   android_clang_dbg_recipe   linux_android_rel_ng   chromeos_daisy_chromium_compile_only_ng   android_arm64_dbg_recipe   win_chromium_x64_rel_ng   linux_chromium_asan_rel_ng   chromium_presubmit   win_chromium_compile_dbg_ng   android_n5x_swarming_rel   linux_chromium_tsan_rel_ng   ios-simulator-xcode-clang   linux_chromium_compile_dbg_ng   linux_chromium_chromeos_rel_ng   ios-device   chromeos_amd64-generic_chromium_compile_only_ng   win_chromium_rel_ng   android_compile_dbg   android_cronet   mac_chromium_compile_dbg_ng   mac_chromium_rel_ng   linux_chromium_rel_ng 
Commit queue not available (can’t edit this change).

Dependent Patchsets:

Messages

Total messages: 20 (16 generated)
vabr (Chromium)
Hi Vadym, Could you please have a look? Thanks! Vaclav
3 months, 1 week ago (2017-03-20 05:59:16 UTC) #14
dvadym (OOO till June 26)
LGTM
3 months, 1 week ago (2017-03-20 10:43:13 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2754273003/80001
3 months ago (2017-03-20 18:15:31 UTC) #17
commit-bot: I haz the power
3 months ago (2017-03-20 20:09:17 UTC) #20
Message was sent while issue was closed.
Committed patchset #4 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/1506f35e2a82f1b50ba2aa51e61c...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cb946e318