Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(301)

Issue 2758773002: Introduce PasswordFormManager::GrabFetcher (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 months, 1 week ago by vabr (Chromium)
Modified:
4 months ago
Reviewers:
kolos1
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Introduce PasswordFormManager::GrabFetcher This allows to attach a FormFetcher instance to a PasswordFormManager (PFM). Normally, when multiple PFM are sharing one FormFetcher, neither of them owns it. But when a single PFM is getting passed across multiple classes, such as during saving a password via the bubble UI, it is more practical to have the FormFetcher attached to the PFM. See https://docs.google.com/document/d/12CH_SV1gIJKaEIGTs7gWBiXrCMlBa3o32OyC2LRtPAo/edit#heading=h.jz2q52kebs7k for more details. BUG=621355 Review-Url: https://codereview.chromium.org/2758773002 Cr-Commit-Position: refs/heads/master@{#458173} Committed: https://chromium.googlesource.com/chromium/src/+/38465cdc3c25e919951c20eaae77de26ea2ccf9d

Patch Set 1 : Needs to also introduce FF:RemoveConsumer #

Patch Set 2 : Grab -> RemoveConsumer #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -4 lines) Patch
M components/password_manager/core/browser/password_form_manager.h View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M components/password_manager/core/browser/password_form_manager.cc View 1 2 1 chunk +6 lines, -1 line 0 comments Download
M components/password_manager/core/browser/password_form_manager_unittest.cc View 1 2 1 chunk +45 lines, -0 lines 0 comments Download
Trybot results:  chromium_presubmit   linux_chromium_asan_rel_ng   linux_android_rel_ng   linux_chromium_tsan_rel_ng   ios-simulator   ios-device-xcode-clang   ios-device   win_clang   win_chromium_compile_dbg_ng   mac_chromium_compile_dbg_ng   ios-simulator-xcode-clang   win_chromium_rel_ng   mac_chromium_rel_ng   win_chromium_x64_rel_ng   linux_chromium_chromeos_rel_ng   cast_shell_android   android_clang_dbg_recipe   linux_chromium_compile_dbg_ng   chromium_presubmit   android_arm64_dbg_recipe   chromeos_amd64-generic_chromium_compile_only_ng   chromeos_daisy_chromium_compile_only_ng   cast_shell_linux   linux_android_rel_ng   linux_chromium_asan_rel_ng   linux_chromium_rel_ng   android_cronet   linux_chromium_chromeos_ozone_rel_ng   android_compile_dbg   android_n5x_swarming_rel   win_chromium_rel_ng   win_chromium_x64_rel_ng   win_chromium_x64_rel_ng   win_clang   android_clang_dbg_recipe   chromeos_daisy_chromium_compile_only_ng   ios-simulator   linux_chromium_chromeos_ozone_rel_ng   cast_shell_android   linux_chromium_chromeos_rel_ng   ios-device-xcode-clang   win_chromium_rel_ng   android_n5x_swarming_rel   android_cronet   chromium_presubmit   linux_chromium_compile_dbg_ng   linux_chromium_asan_rel_ng   linux_android_rel_ng   ios-device   android_arm64_dbg_recipe   win_chromium_compile_dbg_ng   linux_chromium_rel_ng   cast_shell_linux   android_compile_dbg   mac_chromium_compile_dbg_ng   chromeos_amd64-generic_chromium_compile_only_ng   linux_chromium_tsan_rel_ng   ios-simulator-xcode-clang   mac_chromium_rel_ng 
Commit queue not available (can’t edit this change).

Depends on Patchset:

Messages

Total messages: 16 (12 generated)
vabr (Chromium)
Hi Maxim, Could you please review this CL? Thanks, Vaclav
6 months ago (2017-03-20 05:59:57 UTC) #6
kolos1
LGTM
6 months ago (2017-03-20 11:53:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2758773002/40001
6 months ago (2017-03-20 20:35:32 UTC) #13
commit-bot: I haz the power
6 months ago (2017-03-20 20:43:29 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/38465cdc3c25e919951c20eaae77...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld b40b6558b