DescriptionIntroduce restricted PasswordFormManager::GrabFetcher
This CL introduces a version of PasswordFormManager::GrabFetcher where
the attached FormFetcher must be the same which was already associated
to the PasswordFormManager.
The CL also uses that new method to get rid of the redundant
CredentialManagerPasswordFormManager::form_fetcher_ in favour of
PasswordFormManager::owned_form_fetcher_.
While ultimately the restriction on GrabFetcher will be lifted in
https://codereview.chromium.org/2758773002/, the restricted form of
GrabFetcher is a pre-requisite for ensuring the correct lifetime of the owned
FormFetcher in CredentialManagerPasswordFormManager in
https://codereview.chromium.org/2760653002/, which itself is a pre-requisite
of the unrestricted version of GrabFetcher.
See
https://docs.google.com/document/d/12CH_SV1gIJKaEIGTs7gWBiXrCMlBa3o32OyC2LRtPAo/edit#heading=h.jz2q52kebs7k
for more details.
BUG=621355
Review-Url: https://codereview.chromium.org/2754273003
Cr-Commit-Position: refs/heads/master@{#458157}
Committed: https://chromium.googlesource.com/chromium/src/+/1506f35e2a82f1b50ba2aa51e61c60891dc8cbcc
Patch Set 1 #Patch Set 2 : Introduce restricted PasswordFormManager::GrabFetcher #Patch Set 3 : Fix compilation #Patch Set 4 : Remove redundant CredentialManagerPasswordFormManager::form_fetcher_ #
Dependent Patchsets: Messages
Total messages: 20 (16 generated)
|