Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Side by Side Diff: components/password_manager/core/browser/credential_manager_password_form_manager.cc

Issue 2754273003: Introduce restricted PasswordFormManager::GrabFetcher (Closed)
Patch Set: Remove redundant CredentialManagerPasswordFormManager::form_fetcher_ Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2014 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/password_manager/core/browser/credential_manager_password_f orm_manager.h" 5 #include "components/password_manager/core/browser/credential_manager_password_f orm_manager.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/callback.h" 9 #include "base/callback.h"
10 #include "base/macros.h" 10 #include "base/macros.h"
(...skipping 19 matching lines...) Expand all
30 : PasswordFormManager(driver->GetPasswordManager(), 30 : PasswordFormManager(driver->GetPasswordManager(),
31 client, 31 client,
32 driver, 32 driver,
33 observed_form, 33 observed_form,
34 (form_saver ? std::move(form_saver) 34 (form_saver ? std::move(form_saver)
35 : base::MakeUnique<FormSaverImpl>( 35 : base::MakeUnique<FormSaverImpl>(
36 client->GetPasswordStore())), 36 client->GetPasswordStore())),
37 form_fetcher.get()), 37 form_fetcher.get()),
38 delegate_(delegate), 38 delegate_(delegate),
39 saved_form_(std::move(saved_form)), 39 saved_form_(std::move(saved_form)),
40 form_fetcher_(std::move(form_fetcher)),
41 weak_factory_(this) { 40 weak_factory_(this) {
42 DCHECK(saved_form_); 41 DCHECK(saved_form_);
43 // This condition is only false on iOS. 42 // This condition is only false on iOS.
44 if (form_fetcher_) 43 if (form_fetcher)
45 form_fetcher_->Fetch(); 44 form_fetcher->Fetch();
45 GrabFetcher(std::move(form_fetcher));
46 } 46 }
47 47
48 CredentialManagerPasswordFormManager::~CredentialManagerPasswordFormManager() { 48 CredentialManagerPasswordFormManager::~CredentialManagerPasswordFormManager() {
49 } 49 }
50 50
51 void CredentialManagerPasswordFormManager::ProcessMatches( 51 void CredentialManagerPasswordFormManager::ProcessMatches(
52 const std::vector<const PasswordForm*>& non_federated, 52 const std::vector<const PasswordForm*>& non_federated,
53 size_t filtered_count) { 53 size_t filtered_count) {
54 PasswordFormManager::ProcessMatches(non_federated, filtered_count); 54 PasswordFormManager::ProcessMatches(non_federated, filtered_count);
55 55
(...skipping 10 matching lines...) Expand all
66 FROM_HERE, 66 FROM_HERE,
67 base::Bind(&CredentialManagerPasswordFormManager::NotifyDelegate, 67 base::Bind(&CredentialManagerPasswordFormManager::NotifyDelegate,
68 weak_factory_.GetWeakPtr())); 68 weak_factory_.GetWeakPtr()));
69 } 69 }
70 70
71 void CredentialManagerPasswordFormManager::NotifyDelegate() { 71 void CredentialManagerPasswordFormManager::NotifyDelegate() {
72 delegate_->OnProvisionalSaveComplete(); 72 delegate_->OnProvisionalSaveComplete();
73 } 73 }
74 74
75 } // namespace password_manager 75 } // namespace password_manager
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698