Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: components/password_manager/core/browser/password_form_manager.h

Issue 2754273003: Introduce restricted PasswordFormManager::GrabFetcher (Closed)
Patch Set: Remove redundant CredentialManagerPasswordFormManager::form_fetcher_ Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_form_manager.h
diff --git a/components/password_manager/core/browser/password_form_manager.h b/components/password_manager/core/browser/password_form_manager.h
index eb9d1d98728d85c80d124618d2a7ad2486846e09..0f83f152f26e49117002ec292514b84a1c8236dc 100644
--- a/components/password_manager/core/browser/password_form_manager.h
+++ b/components/password_manager/core/browser/password_form_manager.h
@@ -246,6 +246,11 @@ class PasswordFormManager : public FormFetcher::Consumer {
// owned by the associated FormFetcher.
void ResetStoredMatches();
+ // Takes ownership of |fetcher|.
+ // TODO(crbug.com/621355) Until https://codereview.chromium.org/2758773002/,
+ // |fetcher.get()| must be the same as |form_fetcher_|.
+ void GrabFetcher(std::unique_ptr<FormFetcher> fetcher);
+
protected:
// FormFetcher::Consumer:
void ProcessMatches(
@@ -565,7 +570,7 @@ class PasswordFormManager : public FormFetcher::Consumer {
std::unique_ptr<FormFetcher> owned_form_fetcher_;
// FormFetcher instance which owns the login data from PasswordStore.
- FormFetcher* const form_fetcher_;
+ FormFetcher* form_fetcher_;
// True if the main frame's visible URL, at the time this PasswordFormManager
// was created, is secure.

Powered by Google App Engine
This is Rietveld 408576698