Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(979)

Issue 2760653002: Add FormFetcher::RemoveConsumer (Closed)

Created:
1 year, 1 month ago by vabr (Chromium)
Modified:
1 year, 1 month ago
Reviewers:
vasilii
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add FormFetcher::RemoveConsumer This allows to detach a consumer from a FormFetcher, the opposite of AddConsumer. It will be needed for two use-cases which will come in future CLs: (1) When multiple PasswordFormManagers (PFM) will share one FormFetcher, which will thus need to outlive the PFMs. Keeping dangling Consumers would result in use after free. (2) When implementing PasswordFormManager::GrabFetcher the PFM will need to stop listening to the old FormFetcher. More details in https://docs.google.com/document/d/12CH_SV1gIJKaEIGTs7gWBiXrCMlBa3o32OyC2LRtPAo/edit#heading=h.jz2q52kebs7k BUG=621355 Review-Url: https://codereview.chromium.org/2760653002 Cr-Commit-Position: refs/heads/master@{#458166} Committed: https://chromium.googlesource.com/chromium/src/+/5ed0e12d08834914062752a7508658e121de214f

Patch Set 1 #

Patch Set 2 : Rebased #

Messages

Total messages: 22 (17 generated)
vabr (Chromium)
Hi Vasilii, Could you please review this CL? Thanks, Vaclav
1 year, 1 month ago (2017-03-20 06:00:23 UTC) #11
vasilii
lgtm Fix the description. I didn't get the sentence about "love longer".
1 year, 1 month ago (2017-03-20 13:14:12 UTC) #12
vabr (Chromium)
On 2017/03/20 13:14:12, vasilii wrote: > Fix the description. I didn't get the sentence about ...
1 year, 1 month ago (2017-03-20 18:13:59 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2760653002/20001
1 year, 1 month ago (2017-03-20 20:16:41 UTC) #19
commit-bot: I haz the power
1 year, 1 month ago (2017-03-20 20:24:21 UTC) #22
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5ed0e12d08834914062752a75086...

Powered by Google App Engine
This is Rietveld 408576698