Add FormFetcher::RemoveConsumer

Add FormFetcher::RemoveConsumer

This allows to detach a consumer from a FormFetcher, the opposite of
AddConsumer. It will be needed for two use-cases which will come in future CLs:

(1) When multiple PasswordFormManagers (PFM) will share one FormFetcher, which
    will thus need to outlive the PFMs. Keeping dangling Consumers
    would result in use after free.
(2) When implementing PasswordFormManager::GrabFetcher the PFM will need to
    stop listening to the old FormFetcher.

More details in https://docs.google.com/document/d/12CH_SV1gIJKaEIGTs7gWBiXrCMlBa3o32OyC2LRtPAo/edit#heading=h.jz2q52kebs7k

BUG=621355
Review-Url: https://codereview.chromium.org/2760653002
Cr-Commit-Position: refs/heads/master@{#458166}
Committed: https://chromium.googlesource.com/chromium/src/+/5ed0e12d08834914062752a7508658e121de214f

[vabr (Chromium), 2017-03-17 16:39:28]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-17 16:39:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vabr (Chromium), 2017-03-17 16:40:17]

Description was changed from

==========
Add FormFetcher::RemoveConsumer

This allows to detach a consumer from a FormFetcher, the opposite of
AddConsumer. It will be needed for two use-cases which will come in future CLs:
(1) When multiple PasswordFormManagers (PFM) will share one FormFetcher, which
will thus need to love longer than the PFMs. Keeping dangling Consumers would
result in use after free.  (2) When implementing
PasswordFormManager::GrabFetcher the PFM will need to stop listening to the old
FormFetcher.

BUG=621355
==========

to

==========
Add FormFetcher::RemoveConsumer

This allows to detach a consumer from a FormFetcher, the opposite of
AddConsumer. It will be needed for two use-cases which will come in future CLs:

(1) When multiple PasswordFormManagers (PFM) will share one FormFetcher, which
    will thus need to love longer than the PFMs. Keeping dangling Consumers
    would result in use after free.
(2) When implementing PasswordFormManager::GrabFetcher the PFM will need to
    stop listening to the old FormFetcher.

More details in
https://docs.google.com/document/d/12CH_SV1gIJKaEIGTs7gWBiXrCMlBa3o32OyC2LRtP...

BUG=621355
==========

[commit-bot: I haz the power, 2017-03-17 17:06:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 17:06:04]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[vabr (Chromium), 2017-03-17 23:03:31]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-17 23:04:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-18 01:58:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-18 01:58:57]

Dry run: This issue passed the CQ dry run.

[vabr (Chromium), 2017-03-20 06:00:22]

vabr@chromium.org changed reviewers:
+ vasilii@chromium.org

[vabr (Chromium), 2017-03-20 06:00:23]

Hi Vasilii,

Could you please review this CL?

Thanks,
Vaclav

[vasilii, 2017-03-20 13:14:12]

lgtm

Fix the description. I didn't get the sentence about "love longer".

[vabr (Chromium), 2017-03-20 18:13:11]

Description was changed from

==========
Add FormFetcher::RemoveConsumer

This allows to detach a consumer from a FormFetcher, the opposite of
AddConsumer. It will be needed for two use-cases which will come in future CLs:

(1) When multiple PasswordFormManagers (PFM) will share one FormFetcher, which
    will thus need to love longer than the PFMs. Keeping dangling Consumers
    would result in use after free.
(2) When implementing PasswordFormManager::GrabFetcher the PFM will need to
    stop listening to the old FormFetcher.

More details in
https://docs.google.com/document/d/12CH_SV1gIJKaEIGTs7gWBiXrCMlBa3o32OyC2LRtP...

BUG=621355
==========

to

==========
Add FormFetcher::RemoveConsumer

This allows to detach a consumer from a FormFetcher, the opposite of
AddConsumer. It will be needed for two use-cases which will come in future CLs:

(1) When multiple PasswordFormManagers (PFM) will share one FormFetcher, which
    will thus need to outlive the PFMs. Keeping dangling Consumers
    would result in use after free.
(2) When implementing PasswordFormManager::GrabFetcher the PFM will need to
    stop listening to the old FormFetcher.

More details in
https://docs.google.com/document/d/12CH_SV1gIJKaEIGTs7gWBiXrCMlBa3o32OyC2LRtP...

BUG=621355
==========

[vabr (Chromium), 2017-03-20 18:13:59]

On 2017/03/20 13:14:12, vasilii wrote:
> Fix the description. I didn't get the sentence about "love longer".

Thanks!

Sorry for the typo, I meant "live longer". I changed it to "outlive", please let
me know if there are more places in need of clarification.

Cheers,
Vaclav

[vabr (Chromium), 2017-03-20 18:31:43]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-20 18:33:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vabr (Chromium), 2017-03-20 20:15:47]

The CQ bit was unchecked by vabr@chromium.org

[vabr (Chromium), 2017-03-20 20:15:59]

The CQ bit was checked by vabr@chromium.org

[commit-bot: I haz the power, 2017-03-20 20:16:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 20:23:34]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490040959141840,
"parent_rev": "5ee95709dd07c47f2a794eb1cf14762274b678b9", "commit_rev":
"5ed0e12d08834914062752a7508658e121de214f"}

[commit-bot: I haz the power, 2017-03-20 20:24:20]

Description was changed from

==========
Add FormFetcher::RemoveConsumer

This allows to detach a consumer from a FormFetcher, the opposite of
AddConsumer. It will be needed for two use-cases which will come in future CLs:

(1) When multiple PasswordFormManagers (PFM) will share one FormFetcher, which
    will thus need to outlive the PFMs. Keeping dangling Consumers
    would result in use after free.
(2) When implementing PasswordFormManager::GrabFetcher the PFM will need to
    stop listening to the old FormFetcher.

More details in
https://docs.google.com/document/d/12CH_SV1gIJKaEIGTs7gWBiXrCMlBa3o32OyC2LRtP...

BUG=621355
==========

to

==========
Add FormFetcher::RemoveConsumer

This allows to detach a consumer from a FormFetcher, the opposite of
AddConsumer. It will be needed for two use-cases which will come in future CLs:

(1) When multiple PasswordFormManagers (PFM) will share one FormFetcher, which
    will thus need to outlive the PFMs. Keeping dangling Consumers
    would result in use after free.
(2) When implementing PasswordFormManager::GrabFetcher the PFM will need to
    stop listening to the old FormFetcher.

More details in
https://docs.google.com/document/d/12CH_SV1gIJKaEIGTs7gWBiXrCMlBa3o32OyC2LRtP...

BUG=621355

Review-Url: https://codereview.chromium.org/2760653002
Cr-Commit-Position: refs/heads/master@{#458166}
Committed:
https://chromium.googlesource.com/chromium/src/+/5ed0e12d08834914062752a75086...
==========

[commit-bot: I haz the power, 2017-03-20 20:24:21]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5ed0e12d08834914062752a75086...