Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(30)

Issue 2760653002: Add FormFetcher::RemoveConsumer (Closed)

Created:
8 months ago by vabr (Chromium)
Modified:
8 months ago
Reviewers:
vasilii
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add FormFetcher::RemoveConsumer This allows to detach a consumer from a FormFetcher, the opposite of AddConsumer. It will be needed for two use-cases which will come in future CLs: (1) When multiple PasswordFormManagers (PFM) will share one FormFetcher, which will thus need to outlive the PFMs. Keeping dangling Consumers would result in use after free. (2) When implementing PasswordFormManager::GrabFetcher the PFM will need to stop listening to the old FormFetcher. More details in https://docs.google.com/document/d/12CH_SV1gIJKaEIGTs7gWBiXrCMlBa3o32OyC2LRtPAo/edit#heading=h.jz2q52kebs7k BUG=621355 Review-Url: https://codereview.chromium.org/2760653002 Cr-Commit-Position: refs/heads/master@{#458166} Committed: https://chromium.googlesource.com/chromium/src/+/5ed0e12d08834914062752a7508658e121de214f

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -3 lines) Patch
M components/password_manager/core/browser/fake_form_fetcher.h View 1 chunk +2 lines, -0 lines 0 comments Download
M components/password_manager/core/browser/fake_form_fetcher.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M components/password_manager/core/browser/form_fetcher.h View 1 chunk +3 lines, -0 lines 0 comments Download
M components/password_manager/core/browser/form_fetcher_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/password_manager/core/browser/form_fetcher_impl.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M components/password_manager/core/browser/form_fetcher_impl_unittest.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M components/password_manager/core/browser/password_form_manager.h View 1 2 chunks +4 lines, -2 lines 0 comments Download
M components/password_manager/core/browser/password_form_manager.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M components/password_manager/core/browser/password_form_manager_unittest.cc View 1 3 chunks +19 lines, -1 line 0 comments Download
Trybot results:  chromium_presubmit   linux_chromium_asan_rel_ng   linux_android_rel_ng   ios-simulator   ios-device   linux_chromium_chromeos_rel_ng   linux_android_rel_ng   win_chromium_compile_dbg_ng   chromeos_amd64-generic_chromium_compile_only_ng   android_clang_dbg_recipe   linux_chromium_asan_rel_ng   linux_chromium_rel_ng   mac_chromium_compile_dbg_ng   ios-simulator-xcode-clang   android_arm64_dbg_recipe   android_compile_dbg   linux_chromium_compile_dbg_ng   cast_shell_linux   android_cronet   mac_chromium_rel_ng   win_clang   android_n5x_swarming_rel   win_chromium_rel_ng   cast_shell_android   linux_chromium_tsan_rel_ng   linux_chromium_chromeos_ozone_rel_ng   ios-device-xcode-clang   chromeos_daisy_chromium_compile_only_ng   chromium_presubmit   win_chromium_x64_rel_ng   win_chromium_x64_rel_ng   win_clang   win_chromium_x64_rel_ng   ios-simulator   linux_android_rel_ng   linux_chromium_tsan_rel_ng   mac_chromium_compile_dbg_ng   chromium_presubmit   android_arm64_dbg_recipe   chromeos_amd64-generic_chromium_compile_only_ng   linux_chromium_rel_ng   android_cronet   win_chromium_compile_dbg_ng   win_chromium_rel_ng   ios-simulator-xcode-clang   linux_chromium_chromeos_ozone_rel_ng   linux_chromium_compile_dbg_ng   android_clang_dbg_recipe   linux_chromium_chromeos_rel_ng   android_n5x_swarming_rel   linux_chromium_asan_rel_ng   mac_chromium_rel_ng   chromeos_daisy_chromium_compile_only_ng   ios-device   android_compile_dbg   ios-device-xcode-clang   cast_shell_linux   cast_shell_android 

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 22 (17 generated)
vabr (Chromium)
Hi Vasilii, Could you please review this CL? Thanks, Vaclav
8 months ago (2017-03-20 06:00:23 UTC) #11
vasilii
lgtm Fix the description. I didn't get the sentence about "love longer".
8 months ago (2017-03-20 13:14:12 UTC) #12
vabr (Chromium)
On 2017/03/20 13:14:12, vasilii wrote: > Fix the description. I didn't get the sentence about ...
8 months ago (2017-03-20 18:13:59 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2760653002/20001
8 months ago (2017-03-20 20:16:41 UTC) #19
commit-bot: I haz the power
8 months ago (2017-03-20 20:24:21 UTC) #22
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5ed0e12d08834914062752a75086...

Powered by Google App Engine
This is Rietveld efc10ee0f