components/password_manager/core/browser/credential_manager_password_form_manager.cc - Issue 2754273003: Introduce restricted PasswordFormManager::GrabFetcher

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/credential_manager_password_form_manager.cc

Issue 2754273003: Introduce restricted PasswordFormManager::GrabFetcher (Closed)

Patch Set: Remove redundant CredentialManagerPasswordFormManager::form_fetcher_ Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/credential_manager_password_form_manager.h ('k') | components/password_manager/core/browser/password_form_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/credential_manager_password_form_manager.cc

diff --git a/components/password_manager/core/browser/credential_manager_password_form_manager.cc b/components/password_manager/core/browser/credential_manager_password_form_manager.cc

index 0677a17f1c345f1d653587f68fadc128f14470bb..4406d199befce93e1b68dcb05f56c52dc476a1d0 100644

--- a/components/password_manager/core/browser/credential_manager_password_form_manager.cc

+++ b/components/password_manager/core/browser/credential_manager_password_form_manager.cc

@@ -37,12 +37,12 @@ CredentialManagerPasswordFormManager::CredentialManagerPasswordFormManager(

form_fetcher.get()),

delegate_(delegate),

saved_form_(std::move(saved_form)),

- form_fetcher_(std::move(form_fetcher)),

weak_factory_(this) {

DCHECK(saved_form_);

// This condition is only false on iOS.

- if (form_fetcher_)

- form_fetcher_->Fetch();

+ if (form_fetcher)

+ form_fetcher->Fetch();

+ GrabFetcher(std::move(form_fetcher));

}

CredentialManagerPasswordFormManager::~CredentialManagerPasswordFormManager() {