Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2750293003: Delete unused AnimatableValue code (Closed)

Created:
3 years, 9 months ago by alancutter (OOO until 2018)
Modified:
3 years, 9 months ago
Reviewers:
Eric Willigers
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, Eric Willigers, rjwright, rwlbuis, shans
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete unused AnimatableValue code Review-Url: https://codereview.chromium.org/2750293003 Cr-Commit-Position: refs/heads/master@{#458364} Committed: https://chromium.googlesource.com/chromium/src/+/297eef179f7362b9c100009f3196bf379c73b353

Patch Set 1 #

Patch Set 2 : Fix unit tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -2709 lines) Patch
M third_party/WebKit/Source/core/BUILD.gn View 1 chunk +0 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/animation/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CompositorAnimationsTest.cpp View 1 3 chunks +10 lines, -35 lines 0 comments Download
M third_party/WebKit/Source/core/animation/KeyframeEffectModelTest.cpp View 1 15 chunks +25 lines, -32 lines 0 comments Download
M third_party/WebKit/Source/core/animation/LegacyStyleInterpolation.h View 2 chunks +1 line, -11 lines 0 comments Download
M third_party/WebKit/Source/core/animation/LegacyStyleInterpolation.cpp View 2 chunks +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/animation/StringKeyframe.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/animatable/AnimatableClipPathOperation.h View 1 1 chunk +1 line, -7 lines 0 comments Download
M third_party/WebKit/Source/core/animation/animatable/AnimatableClipPathOperation.cpp View 1 chunk +0 lines, -37 lines 0 comments Download
M third_party/WebKit/Source/core/animation/animatable/AnimatableColor.h View 1 2 chunks +2 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/animation/animatable/AnimatableColor.cpp View 3 chunks +0 lines, -24 lines 0 comments Download
D third_party/WebKit/Source/core/animation/animatable/AnimatableColorTest.cpp View 1 chunk +0 lines, -115 lines 0 comments Download
M third_party/WebKit/Source/core/animation/animatable/AnimatableDoubleAndBool.h View 1 1 chunk +1 line, -9 lines 0 comments Download
M third_party/WebKit/Source/core/animation/animatable/AnimatableDoubleAndBool.cpp View 1 chunk +1 line, -19 lines 0 comments Download
D third_party/WebKit/Source/core/animation/animatable/AnimatableDoubleAndBoolTest.cpp View 1 chunk +0 lines, -176 lines 0 comments Download
D third_party/WebKit/Source/core/animation/animatable/AnimatableDoubleTest.cpp View 1 chunk +0 lines, -87 lines 0 comments Download
M third_party/WebKit/Source/core/animation/animatable/AnimatableImage.h View 2 chunks +0 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/animation/animatable/AnimatableImage.cpp View 1 chunk +0 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/core/animation/animatable/AnimatableLength.h View 1 chunk +0 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/core/animation/animatable/AnimatableLength.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/animation/animatable/AnimatableLengthBoxAndBool.h View 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/animation/animatable/AnimatableLengthBoxAndBool.cpp View 1 chunk +1 line, -42 lines 0 comments Download
M third_party/WebKit/Source/core/animation/animatable/AnimatableLengthPoint.h View 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/animation/animatable/AnimatableLengthPoint.cpp View 1 chunk +2 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/animation/animatable/AnimatableLengthPoint3D.h View 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/animation/animatable/AnimatableLengthPoint3D.cpp View 1 chunk +3 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/animation/animatable/AnimatableLengthSize.h View 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/animation/animatable/AnimatableLengthSize.cpp View 1 chunk +2 lines, -20 lines 0 comments Download
D third_party/WebKit/Source/core/animation/animatable/AnimatableLengthTest.cpp View 1 chunk +0 lines, -95 lines 0 comments Download
D third_party/WebKit/Source/core/animation/animatable/AnimatableNeutral.h View 1 chunk +0 lines, -63 lines 0 comments Download
D third_party/WebKit/Source/core/animation/animatable/AnimatableNeutralTest.cpp View 1 chunk +0 lines, -41 lines 0 comments Download
M third_party/WebKit/Source/core/animation/animatable/AnimatablePath.h View 1 1 chunk +1 line, -8 lines 0 comments Download
M third_party/WebKit/Source/core/animation/animatable/AnimatablePath.cpp View 1 chunk +1 line, -52 lines 0 comments Download
M third_party/WebKit/Source/core/animation/animatable/AnimatableRepeatable.h View 1 3 chunks +1 line, -14 lines 0 comments Download
M third_party/WebKit/Source/core/animation/animatable/AnimatableRepeatable.cpp View 1 chunk +0 lines, -54 lines 0 comments Download
M third_party/WebKit/Source/core/animation/animatable/AnimatableSVGPaint.h View 1 chunk +2 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/core/animation/animatable/AnimatableSVGPaint.cpp View 1 chunk +4 lines, -31 lines 0 comments Download
M third_party/WebKit/Source/core/animation/animatable/AnimatableShadow.h View 1 chunk +5 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/animation/animatable/AnimatableShadow.cpp View 1 chunk +0 lines, -32 lines 0 comments Download
M third_party/WebKit/Source/core/animation/animatable/AnimatableShapeValue.h View 1 1 chunk +1 line, -7 lines 0 comments Download
M third_party/WebKit/Source/core/animation/animatable/AnimatableShapeValue.cpp View 1 chunk +0 lines, -28 lines 0 comments Download
M third_party/WebKit/Source/core/animation/animatable/AnimatableStrokeDasharrayList.h View 1 2 chunks +5 lines, -13 lines 0 comments Download
D third_party/WebKit/Source/core/animation/animatable/AnimatableStrokeDasharrayList.cpp View 1 chunk +0 lines, -99 lines 0 comments Download
D third_party/WebKit/Source/core/animation/animatable/AnimatableStrokeDasharrayListTest.cpp View 1 chunk +0 lines, -63 lines 0 comments Download
D third_party/WebKit/Source/core/animation/animatable/AnimatableUnknownTest.cpp View 1 chunk +0 lines, -121 lines 0 comments Download
M third_party/WebKit/Source/core/animation/animatable/AnimatableValue.h View 4 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/animation/animatable/AnimatableValue.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/animation/animatable/AnimatableValueKeyframe.h View 1 chunk +5 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/animatable/AnimatableValueKeyframe.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
D third_party/WebKit/Source/core/animation/animatable/AnimatableValueTestHelper.h View 1 chunk +0 lines, -74 lines 0 comments Download
D third_party/WebKit/Source/core/animation/animatable/AnimatableValueTestHelper.cpp View 1 chunk +0 lines, -194 lines 0 comments Download
D third_party/WebKit/Source/core/animation/animatable/AnimatableValueTestHelperTest.cpp View 1 chunk +0 lines, -83 lines 0 comments Download
M third_party/WebKit/Source/core/animation/animatable/AnimatableVisibility.h View 1 1 chunk +1 line, -8 lines 0 comments Download
M third_party/WebKit/Source/core/animation/animatable/AnimatableVisibility.cpp View 1 chunk +0 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/core/animation/css/CSSAnimatableValueFactory.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/AnimatedStyleBuilder.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/AnimatedStyleBuilder.cpp View 2 chunks +11 lines, -783 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
alancutter (OOO until 2018)
3 years, 9 months ago (2017-03-19 22:53:34 UTC) #7
Eric Willigers
lgtm
3 years, 9 months ago (2017-03-20 02:12:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2750293003/20001
3 years, 9 months ago (2017-03-20 04:20:40 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/331417)
3 years, 9 months ago (2017-03-20 07:15:36 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2750293003/20001
3 years, 9 months ago (2017-03-21 07:04:49 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/297eef179f7362b9c100009f3196bf379c73b353
3 years, 9 months ago (2017-03-21 10:04:13 UTC) #17
agrieve
On 2017/03/21 10:04:13, commit-bot: I haz the power wrote: > Committed patchset #2 (id:20001) as ...
3 years, 9 months ago (2017-03-22 16:52:26 UTC) #18
alancutter (OOO until 2018)
3 years, 9 months ago (2017-03-23 02:01:08 UTC) #19
Message was sent while issue was closed.
On 2017/03/22 at 16:52:26, agrieve wrote:
> On 2017/03/21 10:04:13, commit-bot: I haz the power wrote:
> > Committed patchset #2 (id:20001) as
> >
https://chromium.googlesource.com/chromium/src/+/297eef179f7362b9c100009f3196...
> 
> FYI - this reduced libchrome.so on Android by 16kb. Nice work!

Awesome. :D

Powered by Google App Engine
This is Rietveld 408576698