Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1642)

Unified Diff: third_party/WebKit/Source/core/animation/LegacyStyleInterpolation.h

Issue 2750293003: Delete unused AnimatableValue code (Closed)
Patch Set: Fix unit tests Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/animation/LegacyStyleInterpolation.h
diff --git a/third_party/WebKit/Source/core/animation/LegacyStyleInterpolation.h b/third_party/WebKit/Source/core/animation/LegacyStyleInterpolation.h
index b8723a9cf13a2abd96a18dc8d0677d57e45aabf9..375f01044adea94c52692deeda72b32dd652d262 100644
--- a/third_party/WebKit/Source/core/animation/LegacyStyleInterpolation.h
+++ b/third_party/WebKit/Source/core/animation/LegacyStyleInterpolation.h
@@ -9,7 +9,6 @@
#include "core/CoreExport.h"
#include "core/animation/Interpolation.h"
#include "core/animation/PropertyHandle.h"
-#include "core/css/resolver/AnimatedStyleBuilder.h"
#include <memory>
namespace blink {
@@ -27,16 +26,7 @@ class CORE_EXPORT LegacyStyleInterpolation : public Interpolation {
InterpolableAnimatableValue::create(std::move(end)), id));
}
- // 1) convert m_cachedValue into an X
- // 2) shove X into StyleResolverState
- // X can be:
- // (1) a CSSValue (and applied via StyleBuilder::applyProperty)
- // (2) an AnimatableValue (and applied via
- // AnimatedStyleBuilder::applyProperty)
- // (3) a custom value that is inserted directly into the StyleResolverState.
- void apply(StyleResolverState& state) const {
- AnimatedStyleBuilder::applyProperty(id(), state, currentValue().get());
- }
+ void apply(StyleResolverState&) const;
bool isLegacyStyleInterpolation() const final { return true; }

Powered by Google App Engine
This is Rietveld 408576698