Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: third_party/WebKit/Source/core/animation/animatable/AnimatableStrokeDasharrayList.h

Issue 2750293003: Delete unused AnimatableValue code (Closed)
Patch Set: Fix unit tests Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/animation/animatable/AnimatableStrokeDasharrayList.h
diff --git a/third_party/WebKit/Source/core/animation/animatable/AnimatableStrokeDasharrayList.h b/third_party/WebKit/Source/core/animation/animatable/AnimatableStrokeDasharrayList.h
index a28660dd0db36808eb89033f5b737f5ed842adc6..ba0be3b769005d8e7a1c785cebd76083bcf9d6f5 100644
--- a/third_party/WebKit/Source/core/animation/animatable/AnimatableStrokeDasharrayList.h
+++ b/third_party/WebKit/Source/core/animation/animatable/AnimatableStrokeDasharrayList.h
@@ -37,8 +37,7 @@
namespace blink {
-class CORE_EXPORT AnimatableStrokeDasharrayList final
- : public AnimatableRepeatable {
+class AnimatableStrokeDasharrayList final : public AnimatableRepeatable {
public:
~AnimatableStrokeDasharrayList() override {}
@@ -49,18 +48,11 @@ class CORE_EXPORT AnimatableStrokeDasharrayList final
new AnimatableStrokeDasharrayList(std::move(lengths), zoom));
}
- PassRefPtr<SVGDashArray> toSVGDashArray(float zoom) const;
-
- protected:
- PassRefPtr<AnimatableValue> interpolateTo(const AnimatableValue*,
- double fraction) const override;
- bool usesDefaultInterpolationWith(const AnimatableValue*) const override;
-
private:
- AnimatableStrokeDasharrayList(PassRefPtr<SVGDashArray>, float zoom);
- // This will consume the vector passed into it.
- AnimatableStrokeDasharrayList(Vector<RefPtr<AnimatableValue>>& values)
- : AnimatableRepeatable(values) {}
+ AnimatableStrokeDasharrayList(PassRefPtr<SVGDashArray> lengths, float zoom) {
+ for (const Length& dashLength : lengths->vector())
+ m_values.push_back(AnimatableLength::create(dashLength, zoom));
+ }
AnimatableType type() const override { return TypeStrokeDasharrayList; }
};

Powered by Google App Engine
This is Rietveld 408576698