third_party/WebKit/Source/core/animation/css/CSSAnimatableValueFactory.cpp - Issue 2750293003: Delete unused AnimatableValue code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/css/CSSAnimatableValueFactory.cpp

Issue 2750293003: Delete unused AnimatableValue code (Closed)

Patch Set: Fix unit tests Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/animatable/AnimatableVisibility.cpp ('k') | third_party/WebKit/Source/core/css/resolver/AnimatedStyleBuilder.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/css/CSSAnimatableValueFactory.cpp

diff --git a/third_party/WebKit/Source/core/animation/css/CSSAnimatableValueFactory.cpp b/third_party/WebKit/Source/core/animation/css/CSSAnimatableValueFactory.cpp

index c81915678d283b91e3fe5007d3d52546a153c560..ebe7ed42f99edca858375ea8246d892478f94d61 100644

--- a/third_party/WebKit/Source/core/animation/css/CSSAnimatableValueFactory.cpp

+++ b/third_party/WebKit/Source/core/animation/css/CSSAnimatableValueFactory.cpp

@@ -418,7 +418,7 @@ PassRefPtr<AnimatableValue> CSSAnimatableValueFactory::create(

case CSSPropertyBottom:

return createFromLength(style.bottom(), style);

case CSSPropertyBoxShadow:

- return AnimatableShadow::create(style.boxShadow(), style.color());

+ return AnimatableShadow::create(style.boxShadow());

case CSSPropertyClip:

if (style.hasAutoClip()) {

return AnimatableUnknown::create(

@@ -549,7 +549,7 @@ PassRefPtr<AnimatableValue> CSSAnimatableValueFactory::create(

case CSSPropertyTextIndent:

return createFromLength(style.textIndent(), style);

case CSSPropertyTextShadow:

- return AnimatableShadow::create(style.textShadow(), style.color());

+ return AnimatableShadow::create(style.textShadow());

case CSSPropertyTop:

return createFromLength(style.top(), style);

case CSSPropertyWebkitBorderHorizontalSpacing: