Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Unified Diff: third_party/WebKit/Source/core/animation/animatable/AnimatableLength.h

Issue 2750293003: Delete unused AnimatableValue code (Closed)
Patch Set: Fix unit tests Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/animation/animatable/AnimatableLength.h
diff --git a/third_party/WebKit/Source/core/animation/animatable/AnimatableLength.h b/third_party/WebKit/Source/core/animation/animatable/AnimatableLength.h
index 9ed91934a01a4e76f82eb35a3dcab9b3fdf7e5b6..41f0f4f1bf51f560b06dc28aa4048bd698621ce9 100644
--- a/third_party/WebKit/Source/core/animation/animatable/AnimatableLength.h
+++ b/third_party/WebKit/Source/core/animation/animatable/AnimatableLength.h
@@ -44,34 +44,8 @@ class CORE_EXPORT AnimatableLength final : public AnimatableValue {
}
Length getLength(float zoom, ValueRange) const;
- bool hasSameUnits(const AnimatableLength* other) const {
- return m_hasPixels == other->m_hasPixels &&
- m_hasPercent == other->m_hasPercent;
- }
-
- protected:
- PassRefPtr<AnimatableValue> interpolateTo(const AnimatableValue*,
- double fraction) const override;
-
private:
- static PassRefPtr<AnimatableLength> create(double pixels,
- double percent,
- bool hasPixels,
- bool hasPercent) {
- return adoptRef(
- new AnimatableLength(pixels, percent, hasPixels, hasPercent));
- }
AnimatableLength(const Length&, float zoom);
- AnimatableLength(double pixels,
- double percent,
- bool hasPixels,
- bool hasPercent)
- : m_pixels(pixels),
- m_percent(percent),
- m_hasPixels(hasPixels),
- m_hasPercent(hasPercent) {
- DCHECK(m_hasPixels || m_hasPercent);
- }
AnimatableType type() const override { return TypeLength; }
bool equalTo(const AnimatableValue*) const override;

Powered by Google App Engine
This is Rietveld 408576698