third_party/WebKit/Source/core/animation/animatable/AnimatableValueKeyframe.h - Issue 2750293003: Delete unused AnimatableValue code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/animatable/AnimatableValueKeyframe.h

Issue 2750293003: Delete unused AnimatableValue code (Closed)

Patch Set: Fix unit tests Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/animatable/AnimatableValue.cpp ('k') | third_party/WebKit/Source/core/animation/animatable/AnimatableValueKeyframe.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/animatable/AnimatableValueKeyframe.h

diff --git a/third_party/WebKit/Source/core/animation/animatable/AnimatableValueKeyframe.h b/third_party/WebKit/Source/core/animation/animatable/AnimatableValueKeyframe.h

index de01d8c5badca365c17a388fd04042c6ee74877a..90a2a6c02ff9a190a4f40583993760dbbd206b0e 100644

--- a/third_party/WebKit/Source/core/animation/animatable/AnimatableValueKeyframe.h

+++ b/third_party/WebKit/Source/core/animation/animatable/AnimatableValueKeyframe.h

@@ -48,10 +48,13 @@ class CORE_EXPORT AnimatableValueKeyframe : public Keyframe {

return m_value;

}

- bool isNeutral() const final { return m_value->isNeutral(); }

+ bool isNeutral() const final { return false; }

PassRefPtr<Keyframe::PropertySpecificKeyframe> neutralKeyframe(

double offset,

- PassRefPtr<TimingFunction> easing) const final;

+ PassRefPtr<TimingFunction> easing) const final {

+ NOTREACHED();

+ return nullptr;

+ }

PassRefPtr<Interpolation> createInterpolation(

const PropertyHandle&,

const Keyframe::PropertySpecificKeyframe& end) const final;