getClientRects() shouldn't clip against any ancestors.

getClientRects() shouldn't clip against any ancestors.

Inside multicol we used to clip against the column box of each fragment. Since
fragments don't really exist in our implementation (we rather have this tall
flow thread which we slice into columns, when appropriate), we still need to
clip in the block direction, to properly fake the fragments.

Removed fragmentainerInFlowThread(), since it's no longer used. Added a
parameter to the clip rectangle calculation code, to be able to only limit the
clip rectangles in the block direction.

BUG=685927
Review-Url: https://codereview.chromium.org/2750153002
Cr-Commit-Position: refs/heads/master@{#458109}
Committed: https://chromium.googlesource.com/chromium/src/+/350e4e8fb42a8010e96506fc8bbcab6ca75b5639

[mstensho (USE GERRIT), 2017-03-15 20:11:21]

The CQ bit was checked by mstensho@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-15 20:11:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 21:52:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 21:52:55]

Dry run: This issue passed the CQ dry run.

[mstensho (USE GERRIT), 2017-03-15 22:16:44]

mstensho@opera.com changed reviewers:
+ eae@chromium.org

[eae, 2017-03-18 20:23:25]

Do you want to include a test for getBoundingClientRect as well to ensure it
still does the right type of clipping?

https://codereview.chromium.org/2750153002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/multicol/client-rect-overflowing-multicol.html
(right):

https://codereview.chromium.org/2750153002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/multicol/client-rect-overflowing-multicol.html:16:
assert_equals(rect.right, 3988);
A comment explaining the values would be helpful.

[mstensho (USE GERRIT), 2017-03-20 09:38:22]

I also added a test for getBoundingClientRect(), but I'm not sure how useful it
is, or appropriate it is to test basic functionality of getBoundingClientRect()
here. At least not if we can assume that getBoundingClientRect() is implemented
by calling getClientRects() and then unioning them.

Let me know if we should keep it or not.

https://codereview.chromium.org/2750153002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/multicol/client-rect-overflowing-multicol.html
(right):

https://codereview.chromium.org/2750153002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/multicol/client-rect-overflowing-multicol.html:16:
assert_equals(rect.right, 3988);
On 2017/03/18 20:23:25, eae wrote:
> A comment explaining the values would be helpful.
> 

Done.

Also switched to using width/height instead of right/bottom, since that's easier
to follow.

[eae, 2017-03-20 15:48:10]

Thanks and let's keep the test for now, there are some cases where we've seen
them diverge in the past

LGTM

[eae, 2017-03-20 15:48:16]

The CQ bit was checked by eae@chromium.org

[commit-bot: I haz the power, 2017-03-20 15:48:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 17:26:46]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490024896086840,
"parent_rev": "2948f11e04fba5f0dc7244229c542152c97c1624", "commit_rev":
"350e4e8fb42a8010e96506fc8bbcab6ca75b5639"}

[commit-bot: I haz the power, 2017-03-20 17:27:33]

Description was changed from

==========
getClientRects() shouldn't clip against any ancestors.

Inside multicol we used to clip against the column box of each fragment. Since
fragments don't really exist in our implementation (we rather have this tall
flow thread which we slice into columns, when appropriate), we still need to
clip in the block direction, to properly fake the fragments.

Removed fragmentainerInFlowThread(), since it's no longer used. Added a
parameter to the clip rectangle calculation code, to be able to only limit the
clip rectangles in the block direction.

BUG=685927
==========

to

==========
getClientRects() shouldn't clip against any ancestors.

Inside multicol we used to clip against the column box of each fragment. Since
fragments don't really exist in our implementation (we rather have this tall
flow thread which we slice into columns, when appropriate), we still need to
clip in the block direction, to properly fake the fragments.

Removed fragmentainerInFlowThread(), since it's no longer used. Added a
parameter to the clip rectangle calculation code, to be able to only limit the
clip rectangles in the block direction.

BUG=685927

Review-Url: https://codereview.chromium.org/2750153002
Cr-Commit-Position: refs/heads/master@{#458109}
Committed:
https://chromium.googlesource.com/chromium/src/+/350e4e8fb42a8010e96506fc8bbc...
==========

[commit-bot: I haz the power, 2017-03-20 17:27:34]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/350e4e8fb42a8010e96506fc8bbc...