Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Unified Diff: third_party/WebKit/Source/core/layout/FragmentainerIterator.cpp

Issue 2750153002: getClientRects() shouldn't clip against any ancestors. (Closed)
Patch Set: Document tests. Use width/height instead of right/bottom, since that's easier to follow. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/FragmentainerIterator.cpp
diff --git a/third_party/WebKit/Source/core/layout/FragmentainerIterator.cpp b/third_party/WebKit/Source/core/layout/FragmentainerIterator.cpp
index 50f2d0019e24a6ca5d675e68347d52430b07e053..f7b8e61cf21fb8a7db235a9dbf024a404e8ce4aa 100644
--- a/third_party/WebKit/Source/core/layout/FragmentainerIterator.cpp
+++ b/third_party/WebKit/Source/core/layout/FragmentainerIterator.cpp
@@ -77,18 +77,11 @@ LayoutSize FragmentainerIterator::paginationOffset() const {
CoordinateSpaceConversion::Visual);
}
-LayoutRect FragmentainerIterator::fragmentainerInFlowThread() const {
- DCHECK(!atEnd());
- LayoutRect fragmentainerInFlowThread =
- currentGroup().flowThreadPortionRectAt(m_currentFragmentainerIndex);
- m_flowThread.flipForWritingMode(fragmentainerInFlowThread);
- return fragmentainerInFlowThread;
-}
-
-LayoutRect FragmentainerIterator::clipRectInFlowThread() const {
+LayoutRect FragmentainerIterator::clipRectInFlowThread(
+ MultiColumnFragmentainerGroup::ClipRectAxesSelector axesSelector) const {
DCHECK(!atEnd());
LayoutRect clipRect = currentGroup().flowThreadPortionOverflowRectAt(
- m_currentFragmentainerIndex);
+ m_currentFragmentainerIndex, axesSelector);
m_flowThread.flipForWritingMode(clipRect);
return clipRect;
}

Powered by Google App Engine
This is Rietveld 408576698