Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Side by Side Diff: third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.h

Issue 2750153002: getClientRects() shouldn't clip against any ancestors. (Closed)
Patch Set: Document tests. Use width/height instead of right/bottom, since that's easier to follow. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef MultiColumnFragmentainerGroup_h 5 #ifndef MultiColumnFragmentainerGroup_h
6 #define MultiColumnFragmentainerGroup_h 6 #define MultiColumnFragmentainerGroup_h
7 7
8 #include "core/layout/LayoutMultiColumnFlowThread.h" 8 #include "core/layout/LayoutMultiColumnFlowThread.h"
9 #include "wtf/Allocator.h" 9 #include "wtf/Allocator.h"
10 10
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
96 // that positionForPoint() depends on. 96 // that positionForPoint() depends on.
97 enum SnapToColumnPolicy { DontSnapToColumn, SnapToColumn }; 97 enum SnapToColumnPolicy { DontSnapToColumn, SnapToColumn };
98 LayoutPoint visualPointToFlowThreadPoint( 98 LayoutPoint visualPointToFlowThreadPoint(
99 const LayoutPoint& visualPoint, 99 const LayoutPoint& visualPoint,
100 SnapToColumnPolicy = DontSnapToColumn) const; 100 SnapToColumnPolicy = DontSnapToColumn) const;
101 101
102 LayoutRect fragmentsBoundingBox( 102 LayoutRect fragmentsBoundingBox(
103 const LayoutRect& boundingBoxInFlowThread) const; 103 const LayoutRect& boundingBoxInFlowThread) const;
104 104
105 LayoutRect flowThreadPortionRectAt(unsigned columnIndex) const; 105 LayoutRect flowThreadPortionRectAt(unsigned columnIndex) const;
106 LayoutRect flowThreadPortionOverflowRectAt(unsigned columnIndex) const; 106
107 enum ClipRectAxesSelector {
108 // Only limit the clip rectangle in the block direction. Leave inline
109 // position and length at infinity. Certain operations require this. Those
110 // operations would typically ideally want no clipping at all, but in our
111 // implementation we have to clip in the block direction, in order to slice
112 // the flow thread properly into columns.
113 BlockDirectionAxis,
114
115 // Limit the clip rectangle along both axes. This is what to use for
116 // painting and hit testing.
117 BothAxes
118 };
119
120 LayoutRect flowThreadPortionOverflowRectAt(
121 unsigned columnIndex,
122 ClipRectAxesSelector = BothAxes) const;
107 123
108 // Get the first and the last column intersecting the specified block range. 124 // Get the first and the last column intersecting the specified block range.
109 // Note that |logicalBottomInFlowThread| is an exclusive endpoint. 125 // Note that |logicalBottomInFlowThread| is an exclusive endpoint.
110 void columnIntervalForBlockRangeInFlowThread( 126 void columnIntervalForBlockRangeInFlowThread(
111 LayoutUnit logicalTopInFlowThread, 127 LayoutUnit logicalTopInFlowThread,
112 LayoutUnit logicalBottomInFlowThread, 128 LayoutUnit logicalBottomInFlowThread,
113 unsigned& firstColumn, 129 unsigned& firstColumn,
114 unsigned& lastColumn) const; 130 unsigned& lastColumn) const;
115 131
116 // Get the first and the last column intersecting the specified visual 132 // Get the first and the last column intersecting the specified visual
(...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after
204 220
205 private: 221 private:
206 LayoutMultiColumnSet& m_columnSet; 222 LayoutMultiColumnSet& m_columnSet;
207 223
208 Vector<MultiColumnFragmentainerGroup, 1> m_groups; 224 Vector<MultiColumnFragmentainerGroup, 1> m_groups;
209 }; 225 };
210 226
211 } // namespace blink 227 } // namespace blink
212 228
213 #endif // MultiColumnFragmentainerGroup_h 229 #endif // MultiColumnFragmentainerGroup_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698