third_party/WebKit/LayoutTests/fast/multicol/client-rect-overflowing-multicol-2-columns.html - Issue 2750153002: getClientRects() shouldn't clip against any ancestors.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/multicol/client-rect-overflowing-multicol-2-columns.html

Issue 2750153002: getClientRects() shouldn't clip against any ancestors. (Closed)

Patch Set: Document tests. Use width/height instead of right/bottom, since that's easier to follow. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/multicol/client-rect-overflowing-multicol.html ('k') | third_party/WebKit/Source/core/layout/FragmentainerIterator.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <style>body { margin:8px; }</style>

	3 <div style="columns:2; width:25px; column-gap:5px; height:10px; column-fill:auto ;">

	4 <div id="elm" style="margin-left:-20px; margin-top:-25px; width:4000px; heig ht:40px;"></div>

	5 </div>

	6 <script src="../../resources/testharness.js"></script>

	7 <script src="../../resources/testharnessreport.js"></script>

	8 <script>

	9 test(() => {

	10 var elm = document.getElementById("elm");

	11 var rects = elm.getClientRects();

	12 assert_equals(rects.length, 2);

	13 // #elm is offset -20px,-25px relatively to its multicol container, due

	14 // to negative margins. BODY is offset 8px,8px due to its margin. So the

	15 // absolute offset will be (-20px+8px),(-25px+8px) = -12px,-17px. The

	16 // width will be the unclipped bounding box of #elm, while the height

	17 // will be as much as it can fit in the first column. Since there's a

	18 // top margin of -25px, and column height is 10px, we're going to be

	19 // able to fit 10px - (-25px) = 35px.

	20 assert_equals(rects[0].left, -12);

	21 assert_equals(rects[0].top, -17);

	22 assert_equals(rects[0].width, 4000);

	23 assert_equals(rects[0].height, 35);

	24 // Since the first column could fit 35px of #elm's height, there's 5px

	25 // left for it here in the second column.

	26 assert_equals(rects[1].left, 3);

	27 assert_equals(rects[1].top, 8);

	28 assert_equals(rects[1].width, 4000);

	29 assert_equals(rects[1].height, 5);

	30

	31 // Check that the getBoundingClientRect() agrees with the union of the

	32 // two rects above.

	33 var boundingClientRect = elm.getBoundingClientRect();

	34 var left = Math.min(rects[0].left, rects[1].left);

	35 var right = Math.max(rects[0].right, rects[1].right);

	36 var top = Math.min(rects[0].top, rects[1].top);

	37 var bottom = Math.max(rects[0].bottom, rects[1].bottom);

	38 assert_equals(boundingClientRect.left, left);

	39 assert_equals(boundingClientRect.right, right);

	40 assert_equals(boundingClientRect.top, top);

	41 assert_equals(boundingClientRect.bottom, bottom);

	42 }, "getClientRects should include overflow");

	43 </script>

OLD	NEW