Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Unified Diff: third_party/WebKit/Source/core/layout/FragmentainerIterator.h

Issue 2750153002: getClientRects() shouldn't clip against any ancestors. (Closed)
Patch Set: Document tests. Use width/height instead of right/bottom, since that's easier to follow. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/FragmentainerIterator.h
diff --git a/third_party/WebKit/Source/core/layout/FragmentainerIterator.h b/third_party/WebKit/Source/core/layout/FragmentainerIterator.h
index 8f8dccee7f1b12eb9553da1028f124a9a4be99b2..caa993b5eb1f4d26e4761bf25aad3ac4355483f7 100644
--- a/third_party/WebKit/Source/core/layout/FragmentainerIterator.h
+++ b/third_party/WebKit/Source/core/layout/FragmentainerIterator.h
@@ -5,13 +5,13 @@
#ifndef FragmentainerIterator_h
#define FragmentainerIterator_h
+#include "core/layout/MultiColumnFragmentainerGroup.h"
#include "platform/geometry/LayoutRect.h"
namespace blink {
class LayoutFlowThread;
class LayoutMultiColumnSet;
-class MultiColumnFragmentainerGroup;
// Used to find the fragmentainers that intersect with a given portion of the
// flow thread. The portion typically corresponds to the bounds of some
@@ -38,13 +38,11 @@ class FragmentainerIterator {
// flowthread to visual coordinates.
LayoutSize paginationOffset() const;
- // Return the physical content box of the current fragmentainer, relative to
- // the flow thread.
- LayoutRect fragmentainerInFlowThread() const;
-
// Return the physical clip rectangle of the current fragmentainer, relative
// to the flow thread.
- LayoutRect clipRectInFlowThread() const;
+ LayoutRect clipRectInFlowThread(
+ MultiColumnFragmentainerGroup::ClipRectAxesSelector =
+ MultiColumnFragmentainerGroup::BothAxes) const;
private:
const LayoutFlowThread& m_flowThread;

Powered by Google App Engine
This is Rietveld 408576698