third_party/WebKit/LayoutTests/fast/multicol/client-rect-overflowing-multicol.html - Issue 2750153002: getClientRects() shouldn't clip against any ancestors.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/multicol/client-rect-overflowing-multicol.html

Issue 2750153002: getClientRects() shouldn't clip against any ancestors. (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <style>body { margin:8px; }</style>

	3 <div style="columns:1; width:10px; height:200px; column-fill:auto;">

	4 <div id="elm" style="margin-left:-20px; margin-top:-25px; width:4000px; heig ht:40px;"></div>

	5 </div>

	6 <script src="../../resources/testharness.js"></script>

	7 <script src="../../resources/testharnessreport.js"></script>

	8 <script>

	9 test(() => {

	10 var elm = document.getElementById("elm");

	11 var rects = elm.getClientRects();

	12 assert_equals(rects.length, 1);

	13 var rect = rects[0];

	14 assert_equals(rect.left, -12);

	15 assert_equals(rect.top, -17);

	16 assert_equals(rect.right, 3988);
	eae 2017/03/18 20:23:25 A comment explaining the values would be helpful. A comment explaining the values would be helpful. mstensho (USE GERRIT) 2017/03/20 09:38:22 Done. Also switched to using width/height instead Show quoted text On 2017/03/18 20:23:25, eae wrote: > A comment explaining the values would be helpful. > Done. Also switched to using width/height instead of right/bottom, since that's easier to follow.
	17 assert_equals(rect.bottom, 23);

	18 }, "getClientRects should include overflow");

	19 </script>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/multicol/client-rect-overflowing-multicol-2-columns.html » ('j') | no next file with comments »