third_party/WebKit/Source/core/layout/LayoutFlowThread.cpp - Issue 2750153002: getClientRects() shouldn't clip against any ancestors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutFlowThread.cpp

Issue 2750153002: getClientRects() shouldn't clip against any ancestors. (Closed)

Patch Set: Document tests. Use width/height instead of right/bottom, since that's easier to follow. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutFlowThread.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutFlowThread.cpp b/third_party/WebKit/Source/core/layout/LayoutFlowThread.cpp

index 0062a5a7d7fa19f85abaf2804916b110b90d1b4a..237bacac61753464c90959f7a1c38ec97f50d2aa 100644

--- a/third_party/WebKit/Source/core/layout/LayoutFlowThread.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutFlowThread.cpp

@@ -149,7 +149,9 @@ void LayoutFlowThread::absoluteQuadsForDescendant(const LayoutBox& descendant,

LayoutRect fragment = boundingRectInFlowThread;

// We use inclusiveIntersect() because intersect() would reset the

// coordinates for zero-height objects.

- fragment.inclusiveIntersect(iterator.fragmentainerInFlowThread());

+ LayoutRect clipRect = iterator.clipRectInFlowThread(

+ MultiColumnFragmentainerGroup::BlockDirectionAxis);

+ fragment.inclusiveIntersect(clipRect);

fragment.moveBy(-offsetFromFlowThread);

quads.push_back(descendant.localToAbsoluteQuad(FloatRect(fragment), mode));

}