Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 2747273002: cc: Remove AsValue virtual from DisplayItem. (Closed)

Created:
3 years, 9 months ago by danakj
Modified:
3 years, 9 months ago
Reviewers:
enne (OOO)
CC:
cc-bugs_chromium.org, chrishtr, chromium-reviews, vmpstr
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Remove AsValue virtual from DisplayItem. Have DisplayItemList iterate and turn each item into tracing output directly. This makes accessors as needed on DisplayItems. This removes base::trace_event from any public APIs on DisplayItem and DisplayItemList. R=enne@chromium.org BUG=671440 Review-Url: https://codereview.chromium.org/2747273002 Cr-Commit-Position: refs/heads/master@{#456906} Committed: https://chromium.googlesource.com/chromium/src/+/a63104e9dda2b9a1e985505150b0dd370248c399

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+214 lines, -299 lines) Patch
M cc/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D cc/debug/traced_display_item_list.h View 1 chunk +0 lines, -44 lines 0 comments Download
D cc/debug/traced_display_item_list.cc View 1 chunk +0 lines, -27 lines 0 comments Download
M cc/playback/clip_display_item.h View 2 chunks +5 lines, -4 lines 0 comments Download
M cc/playback/clip_display_item.cc View 2 chunks +0 lines, -35 lines 0 comments Download
M cc/playback/clip_path_display_item.h View 3 chunks +2 lines, -4 lines 0 comments Download
M cc/playback/clip_path_display_item.cc View 2 chunks +0 lines, -16 lines 0 comments Download
M cc/playback/compositing_display_item.h View 3 chunks +5 lines, -4 lines 0 comments Download
M cc/playback/compositing_display_item.cc View 2 chunks +0 lines, -23 lines 0 comments Download
M cc/playback/display_item.h View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/playback/display_item_list.h View 3 chunks +12 lines, -3 lines 0 comments Download
M cc/playback/display_item_list.cc View 3 chunks +176 lines, -42 lines 0 comments Download
M cc/playback/display_item_list_unittest.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M cc/playback/drawing_display_item.h View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/playback/drawing_display_item.cc View 1 chunk +0 lines, -27 lines 0 comments Download
M cc/playback/filter_display_item.h View 3 chunks +2 lines, -4 lines 0 comments Download
M cc/playback/filter_display_item.cc View 2 chunks +0 lines, -16 lines 0 comments Download
M cc/playback/float_clip_display_item.h View 2 chunks +2 lines, -4 lines 0 comments Download
M cc/playback/float_clip_display_item.cc View 2 chunks +0 lines, -16 lines 0 comments Download
M cc/playback/raster_source.cc View 1 chunk +1 line, -0 lines 0 comments Download
M cc/playback/transform_display_item.h View 2 chunks +2 lines, -4 lines 0 comments Download
M cc/playback/transform_display_item.cc View 2 chunks +0 lines, -16 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
danakj
3 years, 9 months ago (2017-03-14 20:43:18 UTC) #3
enne (OOO)
lgtm
3 years, 9 months ago (2017-03-14 21:20:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2747273002/1
3 years, 9 months ago (2017-03-14 21:21:31 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-15 00:14:04 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a63104e9dda2b9a1e985505150b0...

Powered by Google App Engine
This is Rietveld 408576698