Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1085)

Side by Side Diff: cc/playback/clip_path_display_item.h

Issue 2747273002: cc: Remove AsValue virtual from DisplayItem. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/playback/clip_display_item.cc ('k') | cc/playback/clip_path_display_item.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CC_PLAYBACK_CLIP_PATH_DISPLAY_ITEM_H_ 5 #ifndef CC_PLAYBACK_CLIP_PATH_DISPLAY_ITEM_H_
6 #define CC_PLAYBACK_CLIP_PATH_DISPLAY_ITEM_H_ 6 #define CC_PLAYBACK_CLIP_PATH_DISPLAY_ITEM_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 9
10 #include <memory> 10 #include <memory>
11 11
12 #include "base/memory/ptr_util.h" 12 #include "base/memory/ptr_util.h"
13 #include "cc/base/cc_export.h" 13 #include "cc/base/cc_export.h"
14 #include "cc/playback/display_item.h" 14 #include "cc/playback/display_item.h"
15 #include "third_party/skia/include/core/SkPath.h" 15 #include "third_party/skia/include/core/SkPath.h"
16 16
17 class SkCanvas; 17 class SkCanvas;
18 18
19 namespace cc { 19 namespace cc {
20 20
21 class CC_EXPORT ClipPathDisplayItem : public DisplayItem { 21 class CC_EXPORT ClipPathDisplayItem : public DisplayItem {
22 public: 22 public:
23 ClipPathDisplayItem(const SkPath& path, bool antialias); 23 ClipPathDisplayItem(const SkPath& path, bool antialias);
24 ~ClipPathDisplayItem() override; 24 ~ClipPathDisplayItem() override;
25 25
26 void Raster(SkCanvas* canvas, 26 void Raster(SkCanvas* canvas,
27 SkPicture::AbortCallback* callback) const override; 27 SkPicture::AbortCallback* callback) const override;
28 void AsValueInto(const gfx::Rect& visual_rect,
29 base::trace_event::TracedValue* array) const override;
30 28
31 size_t ExternalMemoryUsage() const { 29 size_t ExternalMemoryUsage() const {
32 // The size of SkPath's external storage is not currently accounted for (and 30 // The size of SkPath's external storage is not currently accounted for (and
33 // may well be shared anyway). 31 // may well be shared anyway).
34 return 0; 32 return 0;
35 } 33 }
36 int ApproximateOpCount() const { return 1; } 34 int ApproximateOpCount() const { return 1; }
37 35
36 const SkPath& clip_path() const { return clip_path_; }
37
38 private: 38 private:
39 void SetNew(const SkPath& path, bool antialias); 39 void SetNew(const SkPath& path, bool antialias);
40 40
41 SkPath clip_path_; 41 SkPath clip_path_;
42 bool antialias_; 42 bool antialias_;
43 }; 43 };
44 44
45 class CC_EXPORT EndClipPathDisplayItem : public DisplayItem { 45 class CC_EXPORT EndClipPathDisplayItem : public DisplayItem {
46 public: 46 public:
47 EndClipPathDisplayItem(); 47 EndClipPathDisplayItem();
48 ~EndClipPathDisplayItem() override; 48 ~EndClipPathDisplayItem() override;
49 49
50 static std::unique_ptr<EndClipPathDisplayItem> Create() { 50 static std::unique_ptr<EndClipPathDisplayItem> Create() {
51 return base::MakeUnique<EndClipPathDisplayItem>(); 51 return base::MakeUnique<EndClipPathDisplayItem>();
52 } 52 }
53 53
54 void Raster(SkCanvas* canvas, 54 void Raster(SkCanvas* canvas,
55 SkPicture::AbortCallback* callback) const override; 55 SkPicture::AbortCallback* callback) const override;
56 void AsValueInto(const gfx::Rect& visual_rect,
57 base::trace_event::TracedValue* array) const override;
58 56
59 int ApproximateOpCount() const { return 0; } 57 int ApproximateOpCount() const { return 0; }
60 }; 58 };
61 59
62 } // namespace cc 60 } // namespace cc
63 61
64 #endif // CC_PLAYBACK_CLIP_PATH_DISPLAY_ITEM_H_ 62 #endif // CC_PLAYBACK_CLIP_PATH_DISPLAY_ITEM_H_
OLDNEW
« no previous file with comments | « cc/playback/clip_display_item.cc ('k') | cc/playback/clip_path_display_item.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698