Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4420)

Unified Diff: cc/playback/clip_display_item.cc

Issue 2747273002: cc: Remove AsValue virtual from DisplayItem. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/playback/clip_display_item.h ('k') | cc/playback/clip_path_display_item.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/playback/clip_display_item.cc
diff --git a/cc/playback/clip_display_item.cc b/cc/playback/clip_display_item.cc
index 4b4f0df4a23649be1849706a883c0a5a5e1e7ecd..8e9a9cfabe4ff49404f79de34da158f8cdd84238 100644
--- a/cc/playback/clip_display_item.cc
+++ b/cc/playback/clip_display_item.cc
@@ -47,34 +47,6 @@ void ClipDisplayItem::Raster(SkCanvas* canvas,
}
}
-void ClipDisplayItem::AsValueInto(const gfx::Rect& visual_rect,
- base::trace_event::TracedValue* array) const {
- std::string value = base::StringPrintf(
- "ClipDisplayItem rect: [%s] visualRect: [%s]",
- clip_rect_.ToString().c_str(), visual_rect.ToString().c_str());
- for (const SkRRect& rounded_rect : rounded_clip_rects_) {
- base::StringAppendF(
- &value, " rounded_rect: [rect: [%s]",
- gfx::SkRectToRectF(rounded_rect.rect()).ToString().c_str());
- base::StringAppendF(&value, " radii: [");
- SkVector upper_left_radius = rounded_rect.radii(SkRRect::kUpperLeft_Corner);
- base::StringAppendF(&value, "[%f,%f],", upper_left_radius.x(),
- upper_left_radius.y());
- SkVector upper_right_radius =
- rounded_rect.radii(SkRRect::kUpperRight_Corner);
- base::StringAppendF(&value, " [%f,%f],", upper_right_radius.x(),
- upper_right_radius.y());
- SkVector lower_right_radius =
- rounded_rect.radii(SkRRect::kLowerRight_Corner);
- base::StringAppendF(&value, " [%f,%f],", lower_right_radius.x(),
- lower_right_radius.y());
- SkVector lower_left_radius = rounded_rect.radii(SkRRect::kLowerLeft_Corner);
- base::StringAppendF(&value, " [%f,%f]]", lower_left_radius.x(),
- lower_left_radius.y());
- }
- array->AppendString(value);
-}
-
EndClipDisplayItem::EndClipDisplayItem() : DisplayItem(END_CLIP) {}
EndClipDisplayItem::~EndClipDisplayItem() {
@@ -85,11 +57,4 @@ void EndClipDisplayItem::Raster(SkCanvas* canvas,
canvas->restore();
}
-void EndClipDisplayItem::AsValueInto(
- const gfx::Rect& visual_rect,
- base::trace_event::TracedValue* array) const {
- array->AppendString(base::StringPrintf("EndClipDisplayItem visualRect: [%s]",
- visual_rect.ToString().c_str()));
-}
-
} // namespace cc
« no previous file with comments | « cc/playback/clip_display_item.h ('k') | cc/playback/clip_path_display_item.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698