Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2176)

Unified Diff: cc/playback/display_item_list.h

Issue 2747273002: cc: Remove AsValue virtual from DisplayItem. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/playback/display_item.h ('k') | cc/playback/display_item_list.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/playback/display_item_list.h
diff --git a/cc/playback/display_item_list.h b/cc/playback/display_item_list.h
index 5e1ea3d6a1a727079976873c702632ecbe7ce4ff..165f89c3e7c97f45bd0df0a267c63478324a2cd4 100644
--- a/cc/playback/display_item_list.h
+++ b/cc/playback/display_item_list.h
@@ -27,6 +27,12 @@
class SkCanvas;
+namespace base {
+namespace trace_event {
+class TracedValue;
+}
+}
+
namespace cc {
class DisplayItem;
@@ -130,9 +136,6 @@ class CC_EXPORT DisplayItemList
size_t ApproximateMemoryUsage() const;
bool ShouldBeAnalyzedForSolidColor() const;
- std::unique_ptr<base::trace_event::ConvertableToTraceFormat> AsValue(
- bool include_items) const;
-
void EmitTraceSnapshot() const;
void GenerateDiscardableImagesMetadata();
@@ -160,8 +163,14 @@ class CC_EXPORT DisplayItemList
}
private:
+ FRIEND_TEST_ALL_PREFIXES(DisplayItemListTest, AsValueWithNoItems);
+ FRIEND_TEST_ALL_PREFIXES(DisplayItemListTest, AsValueWithItems);
+
~DisplayItemList();
+ std::unique_ptr<base::trace_event::TracedValue> CreateTracedValue(
+ bool include_items) const;
+
RTree rtree_;
// For testing purposes only. Whether to keep visual rects across calls to
// Finalize().
« no previous file with comments | « cc/playback/display_item.h ('k') | cc/playback/display_item_list.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698