Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1134)

Unified Diff: cc/playback/filter_display_item.h

Issue 2747273002: cc: Remove AsValue virtual from DisplayItem. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/playback/drawing_display_item.cc ('k') | cc/playback/filter_display_item.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/playback/filter_display_item.h
diff --git a/cc/playback/filter_display_item.h b/cc/playback/filter_display_item.h
index 6cc77a0dccadec378344489538faeecd845007f8..054fed5e53d27b7b7e32170f8822d828aeb381e5 100644
--- a/cc/playback/filter_display_item.h
+++ b/cc/playback/filter_display_item.h
@@ -28,8 +28,6 @@ class CC_EXPORT FilterDisplayItem : public DisplayItem {
void Raster(SkCanvas* canvas,
SkPicture::AbortCallback* callback) const override;
- void AsValueInto(const gfx::Rect& visual_rect,
- base::trace_event::TracedValue* array) const override;
size_t ExternalMemoryUsage() const {
// FilterOperations doesn't expose its capacity, but size is probably good
@@ -38,6 +36,8 @@ class CC_EXPORT FilterDisplayItem : public DisplayItem {
}
int ApproximateOpCount() const { return 1; }
+ const gfx::RectF& bounds() const { return bounds_; }
+
private:
void SetNew(const FilterOperations& filters,
const gfx::RectF& bounds,
@@ -59,8 +59,6 @@ class CC_EXPORT EndFilterDisplayItem : public DisplayItem {
void Raster(SkCanvas* canvas,
SkPicture::AbortCallback* callback) const override;
- void AsValueInto(const gfx::Rect& visual_rect,
- base::trace_event::TracedValue* array) const override;
int ApproximateOpCount() const { return 0; }
};
« no previous file with comments | « cc/playback/drawing_display_item.cc ('k') | cc/playback/filter_display_item.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698