Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1585)

Unified Diff: cc/playback/compositing_display_item.h

Issue 2747273002: cc: Remove AsValue virtual from DisplayItem. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/playback/clip_path_display_item.cc ('k') | cc/playback/compositing_display_item.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/playback/compositing_display_item.h
diff --git a/cc/playback/compositing_display_item.h b/cc/playback/compositing_display_item.h
index d562e5ed28879e40fe90535e1d5c96aad63521c0..9555973b993f29c8d0eeb780df240b855bf4bb62 100644
--- a/cc/playback/compositing_display_item.h
+++ b/cc/playback/compositing_display_item.h
@@ -33,8 +33,6 @@ class CC_EXPORT CompositingDisplayItem : public DisplayItem {
void Raster(SkCanvas* canvas,
SkPicture::AbortCallback* callback) const override;
- void AsValueInto(const gfx::Rect& visual_rect,
- base::trace_event::TracedValue* array) const override;
size_t ExternalMemoryUsage() const {
// TODO(pdr): Include color_filter's memory here.
@@ -42,6 +40,11 @@ class CC_EXPORT CompositingDisplayItem : public DisplayItem {
}
int ApproximateOpCount() const { return 1; }
+ uint8_t alpha() const { return alpha_; }
+ SkBlendMode xfermode() const { return xfermode_; }
+ bool has_bounds() const { return has_bounds_; }
+ const SkRect& bounds() const { return bounds_; }
+
private:
void SetNew(uint8_t alpha,
SkBlendMode xfermode,
@@ -68,8 +71,6 @@ class CC_EXPORT EndCompositingDisplayItem : public DisplayItem {
void Raster(SkCanvas* canvas,
SkPicture::AbortCallback* callback) const override;
- void AsValueInto(const gfx::Rect& visual_rect,
- base::trace_event::TracedValue* array) const override;
int ApproximateOpCount() const { return 0; }
};
« no previous file with comments | « cc/playback/clip_path_display_item.cc ('k') | cc/playback/compositing_display_item.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698