Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Side by Side Diff: cc/playback/float_clip_display_item.h

Issue 2747273002: cc: Remove AsValue virtual from DisplayItem. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/playback/filter_display_item.cc ('k') | cc/playback/float_clip_display_item.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CC_PLAYBACK_FLOAT_CLIP_DISPLAY_ITEM_H_ 5 #ifndef CC_PLAYBACK_FLOAT_CLIP_DISPLAY_ITEM_H_
6 #define CC_PLAYBACK_FLOAT_CLIP_DISPLAY_ITEM_H_ 6 #define CC_PLAYBACK_FLOAT_CLIP_DISPLAY_ITEM_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 9
10 #include <memory> 10 #include <memory>
11 #include <vector> 11 #include <vector>
12 12
13 #include "base/memory/ptr_util.h" 13 #include "base/memory/ptr_util.h"
14 #include "cc/base/cc_export.h" 14 #include "cc/base/cc_export.h"
15 #include "cc/playback/display_item.h" 15 #include "cc/playback/display_item.h"
16 #include "ui/gfx/geometry/rect_f.h" 16 #include "ui/gfx/geometry/rect_f.h"
17 17
18 class SkCanvas; 18 class SkCanvas;
19 19
20 namespace cc { 20 namespace cc {
21 21
22 class CC_EXPORT FloatClipDisplayItem : public DisplayItem { 22 class CC_EXPORT FloatClipDisplayItem : public DisplayItem {
23 public: 23 public:
24 explicit FloatClipDisplayItem(const gfx::RectF& clip_rect); 24 explicit FloatClipDisplayItem(const gfx::RectF& clip_rect);
25 ~FloatClipDisplayItem() override; 25 ~FloatClipDisplayItem() override;
26 26
27 void Raster(SkCanvas* canvas, 27 void Raster(SkCanvas* canvas,
28 SkPicture::AbortCallback* callback) const override; 28 SkPicture::AbortCallback* callback) const override;
29 void AsValueInto(const gfx::Rect& visual_rect,
30 base::trace_event::TracedValue* array) const override;
31 29
32 size_t ExternalMemoryUsage() const { return 0; } 30 size_t ExternalMemoryUsage() const { return 0; }
33 int ApproximateOpCount() const { return 1; } 31 int ApproximateOpCount() const { return 1; }
34 32
33 const gfx::RectF& clip_rect() const { return clip_rect_; }
34
35 private: 35 private:
36 void SetNew(const gfx::RectF& clip_rect); 36 void SetNew(const gfx::RectF& clip_rect);
37 37
38 gfx::RectF clip_rect_; 38 gfx::RectF clip_rect_;
39 }; 39 };
40 40
41 class CC_EXPORT EndFloatClipDisplayItem : public DisplayItem { 41 class CC_EXPORT EndFloatClipDisplayItem : public DisplayItem {
42 public: 42 public:
43 EndFloatClipDisplayItem(); 43 EndFloatClipDisplayItem();
44 ~EndFloatClipDisplayItem() override; 44 ~EndFloatClipDisplayItem() override;
45 45
46 static std::unique_ptr<EndFloatClipDisplayItem> Create() { 46 static std::unique_ptr<EndFloatClipDisplayItem> Create() {
47 return base::MakeUnique<EndFloatClipDisplayItem>(); 47 return base::MakeUnique<EndFloatClipDisplayItem>();
48 } 48 }
49 49
50 void Raster(SkCanvas* canvas, 50 void Raster(SkCanvas* canvas,
51 SkPicture::AbortCallback* callback) const override; 51 SkPicture::AbortCallback* callback) const override;
52 void AsValueInto(const gfx::Rect& visual_rect,
53 base::trace_event::TracedValue* array) const override;
54 52
55 int ApproximateOpCount() const { return 0; } 53 int ApproximateOpCount() const { return 0; }
56 }; 54 };
57 55
58 } // namespace cc 56 } // namespace cc
59 57
60 #endif // CC_PLAYBACK_FLOAT_CLIP_DISPLAY_ITEM_H_ 58 #endif // CC_PLAYBACK_FLOAT_CLIP_DISPLAY_ITEM_H_
OLDNEW
« no previous file with comments | « cc/playback/filter_display_item.cc ('k') | cc/playback/float_clip_display_item.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698