Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2733093003: DevTools: instrument user callbacks based on generic probes, remove NativeBreakpoint. (Closed)

Created:
3 years, 9 months ago by pfeldman
Modified:
3 years, 9 months ago
Reviewers:
dgozman, alph
CC:
chromium-reviews, caseq+blink_chromium.org, pfeldman+blink_chromium.org, sof, eae+blinkwatch, lushnikov+blink_chromium.org, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews-bindings_chromium.org, devtools-reviews_chromium.org, blink-reviews, apavlov+blink_chromium.org, blink-reviews-frames_chromium.org, kozyatinskiy+blink_chromium.org, pfeldman, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: instrument user callbacks based on generic probes, remove NativeBreakpoint. BUG=695625 Review-Url: https://codereview.chromium.org/2733093003 Cr-Commit-Position: refs/heads/master@{#455290} Committed: https://chromium.googlesource.com/chromium/src/+/d3c77629c73732f7f34ee31e73983a49a4ccd068

Patch Set 1 #

Patch Set 2 : for review #

Patch Set 3 : for review #

Total comments: 6

Patch Set 4 : review comment addressed #

Patch Set 5 : test fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -100 lines) Patch
M third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/event-listener-breakpoints.html View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Element.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/FrameRequestCallbackCollection.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/events/EventTarget.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/DOMTimer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/DOMWindow.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/CodeGeneratorInstrumentation.py View 1 2 3 2 chunks +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.h View 1 3 chunks +14 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp View 1 2 chunks +29 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorInstrumentation.h View 1 2 chunks +0 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorInstrumentation.cpp View 1 4 chunks +3 lines, -58 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorInstrumentation.idl View 1 1 chunk +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/EventListenerBreakpointsSidebarPane.js View 2 chunks +5 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/geolocation/Geolocation.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/notifications/Notification.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (10 generated)
pfeldman
3 years, 9 months ago (2017-03-06 22:34:29 UTC) #2
pfeldman
PTAL
3 years, 9 months ago (2017-03-06 23:23:02 UTC) #6
dgozman
https://codereview.chromium.org/2733093003/diff/80001/third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp File third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp (left): https://codereview.chromium.org/2733093003/diff/80001/third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp#oldcode129 third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp:129: probe::NativeBreakpoint nativeBreakpoint(frame()->document(), What happened to this one? https://codereview.chromium.org/2733093003/diff/80001/third_party/WebKit/Source/core/inspector/InspectorInstrumentation.cpp File ...
3 years, 9 months ago (2017-03-06 23:36:12 UTC) #7
alph
lgtm https://codereview.chromium.org/2733093003/diff/80001/third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp File third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp (left): https://codereview.chromium.org/2733093003/diff/80001/third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp#oldcode129 third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp:129: probe::NativeBreakpoint nativeBreakpoint(frame()->document(), On 2017/03/06 23:36:11, dgozman wrote: > ...
3 years, 9 months ago (2017-03-07 00:22:20 UTC) #8
pfeldman
https://codereview.chromium.org/2733093003/diff/80001/third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp File third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp (left): https://codereview.chromium.org/2733093003/diff/80001/third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp#oldcode129 third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp:129: probe::NativeBreakpoint nativeBreakpoint(frame()->document(), alph@ is right! https://codereview.chromium.org/2733093003/diff/80001/third_party/WebKit/Source/core/inspector/InspectorInstrumentation.cpp File third_party/WebKit/Source/core/inspector/InspectorInstrumentation.cpp (right): ...
3 years, 9 months ago (2017-03-07 00:55:52 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2733093003/120001
3 years, 9 months ago (2017-03-07 00:56:17 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/395257)
3 years, 9 months ago (2017-03-07 02:40:08 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2733093003/120001
3 years, 9 months ago (2017-03-07 21:18:19 UTC) #16
commit-bot: I haz the power
3 years, 9 months ago (2017-03-07 23:39:41 UTC) #19
Message was sent while issue was closed. 
Committed patchset #5 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/d3c77629c73732f7f34ee31e7398...

Powered by Google App Engine
This is Rietveld 408576698