Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.h

Issue 2733093003: DevTools: instrument user callbacks based on generic probes, remove NativeBreakpoint. (Closed)
Patch Set: test fixed Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.h
diff --git a/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.h b/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.h
index 7349008ea0dd514a97ce1bd2ba07173c94d2fca8..608ef9202afc1579863a211e8b89392296e8d86b 100644
--- a/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.h
+++ b/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.h
@@ -47,6 +47,11 @@ class Element;
class InspectorDOMAgent;
class Node;
+namespace probe {
+class ExecuteScript;
+class UserCallback;
+}
+
namespace protocol {
class DictionaryValue;
}
@@ -96,11 +101,12 @@ class CORE_EXPORT InspectorDOMDebuggerAgent final
void didFireWebGLError(const String& errorName);
void didFireWebGLWarning();
void didFireWebGLErrorOrWarning(const String& message);
- void allowNativeBreakpoint(const String& breakpointName,
- const String* targetName,
- bool sync);
- void cancelNativeBreakpoint();
void scriptExecutionBlockedByCSP(const String& directiveText);
+ void will(const probe::ExecuteScript&);
+ void did(const probe::ExecuteScript&);
+ void will(const probe::UserCallback&);
+ void did(const probe::UserCallback&);
+ void breakableLocation(const char* name);
Response disable() override;
void restore() override;
@@ -112,6 +118,10 @@ class CORE_EXPORT InspectorDOMDebuggerAgent final
int depth,
bool pierce,
V8EventListenerInfoList* listeners);
+ void allowNativeBreakpoint(const String& breakpointName,
+ const String* targetName,
+ bool sync);
+ void cancelNativeBreakpoint();
void pauseOnNativeEventIfNeeded(
std::unique_ptr<protocol::DictionaryValue> eventData,
bool synchronous);

Powered by Google App Engine
This is Rietveld 408576698